diff options
| author | Russ Cox <rsc@golang.org> | 2024-05-22 15:03:13 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-05-23 01:16:53 +0000 |
| commit | 05cbbf985fed823a174bf95cc78a7d44f948fdab (patch) | |
| tree | ffdb52c7ce57360323e22a68e20f45d10771a004 /src/database | |
| parent | 1d3d6ae725697c5b224b26cb3aa1325ac37f72d7 (diff) | |
| download | go-05cbbf985fed823a174bf95cc78a7d44f948fdab.tar.xz | |
all: document legacy //go:linkname for modules with ≥500 dependents
For #67401.
Change-Id: I7dd28c3b01a1a647f84929d15412aa43ab0089ee
Reviewed-on: https://go-review.googlesource.com/c/go/+/587575
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/database')
| -rw-r--r-- | src/database/sql/badlinkname.go | 1 | ||||
| -rw-r--r-- | src/database/sql/sql.go | 18 |
2 files changed, 14 insertions, 5 deletions
diff --git a/src/database/sql/badlinkname.go b/src/database/sql/badlinkname.go index a77def9fbd..95a2354afd 100644 --- a/src/database/sql/badlinkname.go +++ b/src/database/sql/badlinkname.go @@ -13,4 +13,3 @@ import _ "unsafe" // in new code. //go:linkname convertAssign -//go:linkname drivers diff --git a/src/database/sql/sql.go b/src/database/sql/sql.go index 9373aa1c58..de774a0510 100644 --- a/src/database/sql/sql.go +++ b/src/database/sql/sql.go @@ -29,12 +29,22 @@ import ( "sync" "sync/atomic" "time" + _ "unsafe" ) -var ( - driversMu sync.RWMutex - drivers = make(map[string]driver.Driver) -) +var driversMu sync.RWMutex + +// drivers should be an internal detail, +// but widely used packages access it using linkname. +// (It is extra wrong that they linkname drivers but not driversMu.) +// Notable members of the hall of shame include: +// - github.com/instana/go-sensor +// +// Do not remove or change the type signature. +// See go.dev/issue/67401. +// +//go:linkname drivers +var drivers = make(map[string]driver.Driver) // nowFunc returns the current time; it's overridden in tests. var nowFunc = time.Now |