diff options
| author | Robert Findley <rfindley@google.com> | 2023-07-07 11:20:16 -0400 |
|---|---|---|
| committer | Robert Findley <rfindley@google.com> | 2023-07-07 19:58:56 +0000 |
| commit | ac9137f8d312c3a6916ab71de61b05c192c455f0 (patch) | |
| tree | 59055abfc03e9acefca888857d99549ffe903abe /src/database/sql | |
| parent | 158d11196f732e4c80b03240548bdd373e6a9eff (diff) | |
| download | go-ac9137f8d312c3a6916ab71de61b05c192c455f0.tar.xz | |
go/types, types2: do not mutate arguments in NewChecker
CL 507975 resulted in new data races (as reported in #61212), because
the pkg argument to NewChecker was mutated.
Fix this by deferring the recording of the goVersion in pkg until type
checking is actually initiated via a call to Checker.Files.
Additionally, modify types2/check.go to bring it in sync with the
changes in go/types/check.go, and generate the new version_test.go from
the types2 file.
Also move parsing the version into checkFiles, for simplicity.
Fixes #61212
Change-Id: I15edb6c2cff3085622fe7c6a3b0dab531d27bd04
Reviewed-on: https://go-review.googlesource.com/c/go/+/508439
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
Diffstat (limited to 'src/database/sql')
0 files changed, 0 insertions, 0 deletions