diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2025-12-10 02:50:56 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2025-12-11 08:34:39 -0800 |
| commit | e38c38f0e539f599216247b5293d5c78aa82468b (patch) | |
| tree | 86a9d0ac8841b29095438821792e185bc4590a0a /src/database/sql/sql.go | |
| parent | c0ba519764536b8ce7ba2a7fe3748f07672f7b6e (diff) | |
| download | go-e38c38f0e539f599216247b5293d5c78aa82468b.tar.xz | |
internal/trace: correctly handle GoUndetermined for GoroutineSummary
Currently the trace summarization incorrectly handles GoUndetermined by
treating it too much like GoNotExist. In particular, it should be
accumulating all the time since the start of the trace in a particular
bucket, but it doesn't, so that instead gets counted as "unknown time"
because the "creation time" is at the start of the trace.
This change fixes the problem by simply doing the accumulation. It's
very straightforward. It also side-steps some other inaccuracies, like
associating a goroutine that is being named with the current task. I
don't think this can ever actually happen in practice, but splitting up
the two cases, GoUndetermined and GoNotExist, fixes it.
Fixes #76716.
Change-Id: I3ac1557044f99c92bada2cb0e124b2192b1d6ebb
Reviewed-on: https://go-review.googlesource.com/c/go/+/728822
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Nick Ripley <nick.ripley@datadoghq.com>
Diffstat (limited to 'src/database/sql/sql.go')
0 files changed, 0 insertions, 0 deletions