diff options
| author | Daniel Theophanes <kardianos@gmail.com> | 2020-03-18 10:03:51 -0700 |
|---|---|---|
| committer | Daniel Theophanes <kardianos@gmail.com> | 2020-03-29 02:01:34 +0000 |
| commit | 5aef51a729f428bfd4b2c28fd2ba7950660608e0 (patch) | |
| tree | b54659cae5f7ff946328b2bb9d2bb200b2f8d1ae /src/database/sql/driver/driver.go | |
| parent | 2ba00e47545406b3dd11436e3f1acf841d4932c6 (diff) | |
| download | go-5aef51a729f428bfd4b2c28fd2ba7950660608e0.tar.xz | |
database/sql: add test for Conn.Validator interface
This addresses comments made by Russ after
https://golang.org/cl/174122 was merged. It addes a test
for the connection validator and renames the interface to just
"Validator".
Change-Id: Iea53e9b250c9be2e86e9b75906e7353e26437c5c
Reviewed-on: https://go-review.googlesource.com/c/go/+/223963
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Diffstat (limited to 'src/database/sql/driver/driver.go')
| -rw-r--r-- | src/database/sql/driver/driver.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/database/sql/driver/driver.go b/src/database/sql/driver/driver.go index a2b844d71f..76f1bd3aa1 100644 --- a/src/database/sql/driver/driver.go +++ b/src/database/sql/driver/driver.go @@ -261,15 +261,15 @@ type SessionResetter interface { ResetSession(ctx context.Context) error } -// ConnectionValidator may be implemented by Conn to allow drivers to +// Validator may be implemented by Conn to allow drivers to // signal if a connection is valid or if it should be discarded. // // If implemented, drivers may return the underlying error from queries, // even if the connection should be discarded by the connection pool. -type ConnectionValidator interface { - // ValidConnection is called prior to placing the connection into the +type Validator interface { + // IsValid is called prior to placing the connection into the // connection pool. The connection will be discarded if false is returned. - ValidConnection() bool + IsValid() bool } // Result is the result of a query execution. |
