aboutsummaryrefslogtreecommitdiff
path: root/src/database/sql/convert_test.go
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2018-01-22 20:07:58 -0500
committerRuss Cox <rsc@golang.org>2018-01-24 16:33:06 +0000
commit8d88c9ae074d4128556785b7b77ef169edd97c99 (patch)
treeb49303d0d91339c4e34a6773d54628a64092e61a /src/database/sql/convert_test.go
parent236abdb46bc13c3e3afe019950d3c3db126190c4 (diff)
downloadgo-8d88c9ae074d4128556785b7b77ef169edd97c99.tar.xz
cmd/go: fix -coverpkg=all with dot imports
If you use -coverpkg=all you get coverage for all packages in the build. Go 1.9 used a global counter for all the GoCover variables, so that they were distinct for the entire build. The global counter caused problems with caching, so we switched to a per-package counter. But now the GoCover_0 in one package may be dot-imported into another and conflict with the GoCover_0 in that other package. Reestablish (overwhelmingly likely) global uniqueness of GoCover variables by appending an _xxxxxxxxxxxx suffix, where the x's are the prefix of the SHA256 hash of the import path. The point is only to avoid accidents, not to defeat people determined to break the tools. Fixes #23432. Change-Id: I3088eceebbe35174f2eefe8d558b7c8b59d3eeac Reviewed-on: https://go-review.googlesource.com/89135 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/database/sql/convert_test.go')
0 files changed, 0 insertions, 0 deletions