diff options
| author | Jonathan Hall <flimzy@flimzy.com> | 2024-07-08 18:14:43 +0200 |
|---|---|---|
| committer | t hepudds <thepudds1460@gmail.com> | 2025-11-21 13:25:48 -0800 |
| commit | 6f16669e346038c983ae33025ca02dccd78b6f20 (patch) | |
| tree | 9ac7d7e3f75048e156c9ca45cac24107e2ef1d65 /src/database/sql/convert.go | |
| parent | 121bc3e464b901327a5c138d8a992bb85c440862 (diff) | |
| download | go-6f16669e346038c983ae33025ca02dccd78b6f20.tar.xz | |
database/sql: don't ignore ColumnConverter for unknown input count
In the case a sql driver implements the ColumnConverter interface and also
returns -1 for NumInputs, indicating an unknown number of input arguments to
a query, the previous implementation would ignore the column converter would
not be called, leading to unexpected or invalid arguments passed to the driver.
Fixes #68342
Change-Id: Ib2ddaf040fa9be669d593eacdaa1e88ba66d7bc2
Reviewed-on: https://go-review.googlesource.com/c/go/+/597115
Reviewed-by: Sean Liao <sean@liao.dev>
Reviewed-by: Mark Freeman <markfreeman@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/database/sql/convert.go')
| -rw-r--r-- | src/database/sql/convert.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/database/sql/convert.go b/src/database/sql/convert.go index 26b139abab..8a0457f9f4 100644 --- a/src/database/sql/convert.go +++ b/src/database/sql/convert.go @@ -55,7 +55,7 @@ func (c ccChecker) CheckNamedValue(nv *driver.NamedValue) error { // it isn't expecting. The final error will be thrown // in the argument converter loop. index := nv.Ordinal - 1 - if c.want <= index { + if c.want >= 0 && c.want <= index { return nil } |