aboutsummaryrefslogtreecommitdiff
path: root/src/crypto
diff options
context:
space:
mode:
authorAustin Clements <austin@google.com>2015-04-23 20:00:10 -0400
committerAustin Clements <austin@google.com>2015-04-24 20:10:10 +0000
commitd1cae6358ccf27bc2c864b09aad49fd8a67ac264 (patch)
tree9f937278239d3f4a557ee040dd17f495a067d48c /src/crypto
parent26eac917dca240b318685ac019e606d02e79e600 (diff)
downloadgo-d1cae6358ccf27bc2c864b09aad49fd8a67ac264.tar.xz
runtime: fix check for pending GC work
When findRunnable considers running a fractional mark worker, it first checks if there's any work to be done; if there isn't there's no point in running the worker because it will just reschedule immediately. However, currently findRunnable just checks work.full and work.partial, whereas getfull can *also* draw work from m.currentwbuf. As a result, findRunnable may not start a worker even though there actually is work. This problem manifests itself in occasional failures of the test/init1.go test. This test is unusual because it performs a large amount of allocation without executing any write barriers, which means there's nothing to force the pointers in currentwbuf out to the work.partial/full lists where findRunnable can see them. This change fixes this problem by making findRunnable also check for a currentwbuf. This aligns findRunnable with trygetfull's notion of whether or not there's work. Change-Id: Ic76d22b7b5d040bc4f58a6b5975e9217650e66c4 Reviewed-on: https://go-review.googlesource.com/9299 Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/crypto')
0 files changed, 0 insertions, 0 deletions