diff options
| author | Daniel McCarney <daniel@binaryparadox.net> | 2025-02-15 10:07:19 -0500 |
|---|---|---|
| committer | Daniel McCarney <daniel@binaryparadox.net> | 2025-03-07 12:37:36 -0800 |
| commit | bc5f4a555e933e6861d12edba4c2d87ef6caf8e6 (patch) | |
| tree | 548e8bc41001d89571ab95f752c5f702ae3f5e4b /src/crypto | |
| parent | e6908846df5f521ba0c927c3ce4a06ed11a6d04c (diff) | |
| download | go-bc5f4a555e933e6861d12edba4c2d87ef6caf8e6.tar.xz | |
crypto/tls: small bogo shim test tidying
1. onResumeShimWritesFirst is unused, replace the binding with an
underscore.
2. in the bogoShim() function when looping through resumeCount+1 the
tlsConn read for loop only breaks for non-nil err, so there's no need
to check that again after the loop body.
Updates #72006
Change-Id: Ieff45d26df33d71003a2509ea5b2b06c5fa0e1d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/650715
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/crypto')
| -rw-r--r-- | src/crypto/tls/bogo_shim_test.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/crypto/tls/bogo_shim_test.go b/src/crypto/tls/bogo_shim_test.go index fdacbee25d..569e627373 100644 --- a/src/crypto/tls/bogo_shim_test.go +++ b/src/crypto/tls/bogo_shim_test.go @@ -82,10 +82,10 @@ var ( expectSessionMiss = flag.Bool("expect-session-miss", false, "") - _ = flag.Bool("enable-early-data", false, "") - _ = flag.Bool("on-resume-expect-accept-early-data", false, "") - _ = flag.Bool("expect-ticket-supports-early-data", false, "") - onResumeShimWritesFirst = flag.Bool("on-resume-shim-writes-first", false, "") + _ = flag.Bool("enable-early-data", false, "") + _ = flag.Bool("on-resume-expect-accept-early-data", false, "") + _ = flag.Bool("expect-ticket-supports-early-data", false, "") + _ = flag.Bool("on-resume-shim-writes-first", false, "") advertiseALPN = flag.String("advertise-alpn", "", "") expectALPN = flag.String("expect-alpn", "", "") @@ -324,7 +324,7 @@ func bogoShim() { break } } - if err != nil && err != io.EOF { + if err != io.EOF { retryErr, ok := err.(*ECHRejectionError) if !ok { log.Fatalf("unexpected error type returned: %v", err) |