crypto/tls: add support for Ed25519 certificates in TLS 1.2 and 1.3

Support for Ed25519 certificates was added in CL 175478, this wires them
up into the TLS stack according to RFC 8422 (TLS 1.2) and RFC 8446 (TLS 1.3).

RFC 8422 also specifies support for TLS 1.0 and 1.1, and I initially
implemented that, but even OpenSSL doesn't take the complexity, so I
just dropped it. It would have required keeping a buffer of the
handshake transcript in order to do the direct Ed25519 signatures. We
effectively need to support TLS 1.2 because it shares ClientHello
signature algorithms with TLS 1.3.

While at it, reordered the advertised signature algorithms in the rough
order we would want to use them, also based on what curves have fast
constant-time implementations.

Client and client auth tests changed because of the change in advertised
signature algorithms in ClientHello and CertificateRequest.

Fixes #25355

Change-Id: I9fdd839afde4fd6b13fcbc5cc7017fd8c35085ee
Reviewed-on: https://go-review.googlesource.com/c/go/+/177698
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>

1 files changed, 31 insertions, 31 deletions

diff --git a/src/crypto/tls/testdata/Server-TLSv12-ClientAuthRequestedNotGiven b/src/crypto/tls/testdata/Server-TLSv12-ClientAuthRequestedNotGiven
index 7b38a99abb..833d331697 100644
--- a/src/crypto/tls/testdata/Server-TLSv12-ClientAuthRequestedNotGiven
+++ b/src/crypto/tls/testdata/Server-TLSv12-ClientAuthRequestedNotGiven
@@ -1,7 +1,7 @@
 >>> Flow 1 (client to server)
-00000000  16 03 01 00 97 01 00 00  93 03 03 23 f3 fb 5f cb  |...........#.._.|
-00000010  3f 63 8a f2 4c c7 41 cd  64 00 4f 7c 63 66 e1 3f  |?c..L.A.d.O|cf.?|
-00000020  b6 8d 4e 24 20 35 9c c5  c3 96 e9 00 00 04 00 2f  |..N$ 5........./|
+00000000  16 03 01 00 97 01 00 00  93 03 03 af 6e 31 55 9f  |............n1U.|
+00000010  fb 22 73 ce a2 0a b6 a3  3e 13 14 83 09 8c e2 98  |."s.....>.......|
+00000020  c3 6f a3 80 79 e4 7c c5  ff 4e a4 00 00 04 00 2f  |.o..y.|..N...../|
 00000030  00 ff 01 00 00 66 00 00  00 0e 00 0c 00 00 09 31  |.....f.........1|
 00000040  32 37 2e 30 2e 30 2e 31  00 0b 00 04 03 00 01 02  |27.0.0.1........|
 00000050  00 0a 00 0c 00 0a 00 1d  00 17 00 1e 00 19 00 18  |................|
@@ -51,37 +51,37 @@
 00000260  f1 6c 04 ed 73 bb b3 43  77 8d 0c 1c f1 0f a1 d8  |.l..s..Cw.......|
 00000270  40 83 61 c9 4c 72 2b 9d  ae db 46 06 06 4d f4 c1  |@.a.Lr+...F..M..|
 00000280  b3 3e c0 d1 bd 42 d4 db  fe 3d 13 60 84 5c 21 d3  |.>...B...=.`.\!.|
-00000290  3b e9 fa e7 16 03 03 00  21 0d 00 00 1d 02 01 40  |;.......!......@|
-000002a0  00 16 08 04 08 05 08 06  04 01 04 03 05 01 05 03  |................|
-000002b0  06 01 06 03 02 01 02 03  00 00 16 03 03 00 04 0e  |................|
-000002c0  00 00 00                                          |...|
+00000290  3b e9 fa e7 16 03 03 00  23 0d 00 00 1f 02 01 40  |;.......#......@|
+000002a0  00 18 08 04 04 03 08 07  08 05 08 06 04 01 05 01  |................|
+000002b0  06 01 05 03 06 03 02 01  02 03 00 00 16 03 03 00  |................|
+000002c0  04 0e 00 00 00                                    |.....|
 >>> Flow 3 (client to server)
 00000000  16 03 03 00 07 0b 00 00  03 00 00 00 16 03 03 00  |................|
-00000010  86 10 00 00 82 00 80 d7  50 22 1d 9e b8 81 12 e5  |........P"......|
-00000020  47 e6 65 cf 82 19 a2 43  9a 5c 7b 44 98 eb d9 ac  |G.e....C.\{D....|
-00000030  e1 4e f5 9d ad bd 0a 0e  17 07 81 b9 b5 4b bb b1  |.N...........K..|
-00000040  95 da 0a 82 67 ba 98 1b  cc 45 91 62 ee 36 eb e3  |....g....E.b.6..|
-00000050  18 30 34 f6 38 ab 3d 0c  a7 2b bd 90 94 49 81 af  |.04.8.=..+...I..|
-00000060  67 a0 f2 b4 0f c0 09 eb  c3 23 24 4b 76 3f cb b9  |g........#$Kv?..|
-00000070  4c a3 53 a7 f6 53 34 1b  24 24 2f cc 24 d8 fb 12  |L.S..S4.$$/.$...|
-00000080  65 60 cf 06 92 c3 7c 63  18 b1 92 88 e3 a8 1d 9c  |e`....|c........|
-00000090  f7 c1 9a a4 af 78 7d 14  03 03 00 01 01 16 03 03  |.....x}.........|
-000000a0  00 40 91 9a 6b 71 c5 3e  88 9a 26 b4 af fa 41 26  |.@..kq.>..&...A&|
-000000b0  72 33 a7 72 9b 22 89 d9  a5 ed 3d 0e 0e af c8 ef  |r3.r."....=.....|
-000000c0  3d c8 89 e4 0d 21 df 06  37 23 0f 50 d1 3e ef af  |=....!..7#.P.>..|
-000000d0  d8 cd 30 cc c4 18 3a 12  49 c0 0a 21 20 cd ac 66  |..0...:.I..! ..f|
-000000e0  96 c3                                             |..|
+00000010  86 10 00 00 82 00 80 5b  78 d7 5b 4f e3 55 1f 34  |.......[x.[O.U.4|
+00000020  60 be e9 68 07 28 c0 42  b1 ff 31 2f ac 41 19 1e  |`..h.(.B..1/.A..|
+00000030  5b c3 7a d4 e4 59 49 4a  ed be b9 95 6c d5 58 4a  |[.z..YIJ....l.XJ|
+00000040  4a f5 ea f7 00 39 8b f0  6a c6 5a 5f 4e 53 40 20  |J....9..j.Z_NS@ |
+00000050  70 88 5a d4 e0 9e 25 a2  d5 50 1e 22 ed 02 14 f9  |p.Z...%..P."....|
+00000060  eb 32 dd d2 9c 66 20 4c  4d a1 97 91 48 6f 39 cf  |.2...f LM...Ho9.|
+00000070  ae e4 33 4e d9 4d 96 fa  13 39 1d b4 16 85 08 4a  |..3N.M...9.....J|
+00000080  8f dc b6 f3 19 05 de 16  aa 3d 5e 71 e7 38 ff 3d  |.........=^q.8.=|
+00000090  77 5b 63 df d2 32 3d 14  03 03 00 01 01 16 03 03  |w[c..2=.........|
+000000a0  00 40 d7 df c5 1f ec 3c  10 77 53 78 8f c7 8a 79  |.@.....<.wSx...y|
+000000b0  17 3a 31 57 6f e3 e8 85  3f 33 75 0a f8 a8 4d cc  |.:1Wo...?3u...M.|
+000000c0  70 0a d9 d0 8b 87 b5 d4  74 c8 8d 30 3b 80 bd 8c  |p.......t..0;...|
+000000d0  cb 42 6f e9 e5 c9 a6 28  16 6d 7a d8 13 cb 57 30  |.Bo....(.mz...W0|
+000000e0  3d 77                                             |=w|
 >>> Flow 4 (server to client)
 00000000  14 03 03 00 01 01 16 03  03 00 40 00 00 00 00 00  |..........@.....|
-00000010  00 00 00 00 00 00 00 00  00 00 00 2d 70 ad 8f ed  |...........-p...|
-00000020  c0 cf ce 73 28 76 8f da  65 41 46 53 dd 06 0d cc  |...s(v..eAFS....|
-00000030  36 cb f3 b8 c7 1f df 53  1a 7d 1e 9f d6 b9 e3 9e  |6......S.}......|
-00000040  fe a8 d9 91 6c 3b d2 ef  b6 30 55 17 03 03 00 40  |....l;...0U....@|
+00000010  00 00 00 00 00 00 00 00  00 00 00 93 43 99 29 17  |............C.).|
+00000020  5b 96 2e 5b 22 fc 53 47  b2 85 76 46 d9 1a f2 12  |[..[".SG..vF....|
+00000030  58 e0 0e 0d 0f dc 88 a2  0f b1 00 39 ed d7 99 58  |X..........9...X|
+00000040  99 7b c5 ba 91 a3 72 05  1e 9e c2 17 03 03 00 40  |.{....r........@|
 00000050  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
-00000060  6a 43 95 20 f0 f9 b4 e0  12 24 ae c1 55 c2 ad ec  |jC. .....$..U...|
-00000070  de 42 1f 0b ff 5b e5 ab  8b aa 72 69 2f 10 12 ca  |.B...[....ri/...|
-00000080  8c f2 77 be 60 81 ef c9  34 dc d7 68 57 d5 17 aa  |..w.`...4..hW...|
+00000060  f3 ff e7 4d b6 ca 7c 95  ed 96 13 88 70 b3 2c 8b  |...M..|.....p.,.|
+00000070  9b 0c 51 77 75 16 b4 c0  df 9f 1a c4 86 68 82 10  |..Qwu........h..|
+00000080  41 c7 1e e5 92 49 ce a3  6f c3 bc 0a 91 04 b6 fa  |A....I..o.......|
 00000090  15 03 03 00 30 00 00 00  00 00 00 00 00 00 00 00  |....0...........|
-000000a0  00 00 00 00 00 c0 4b 9e  e5 6b 45 60 e1 7b 87 b1  |......K..kE`.{..|
-000000b0  76 06 e4 dc d7 01 eb db  04 9c 9b d4 bd 5c e0 18  |v............\..|
-000000c0  72 7a 73 93 4f                                    |rzs.O|
+000000a0  00 00 00 00 00 2c e7 ff  bb 3a f5 00 08 d3 8c 3f  |.....,...:.....?|
+000000b0  89 bf 97 de fc c4 91 59  2f 7b b3 b8 ea d0 b1 05  |.......Y/{......|
+000000c0  ca ff d0 78 9f                                    |...x.|