crypto/tls: add support for Ed25519 certificates in TLS 1.2 and 1.3

Support for Ed25519 certificates was added in CL 175478, this wires them
up into the TLS stack according to RFC 8422 (TLS 1.2) and RFC 8446 (TLS 1.3).

RFC 8422 also specifies support for TLS 1.0 and 1.1, and I initially
implemented that, but even OpenSSL doesn't take the complexity, so I
just dropped it. It would have required keeping a buffer of the
handshake transcript in order to do the direct Ed25519 signatures. We
effectively need to support TLS 1.2 because it shares ClientHello
signature algorithms with TLS 1.3.

While at it, reordered the advertised signature algorithms in the rough
order we would want to use them, also based on what curves have fast
constant-time implementations.

Client and client auth tests changed because of the change in advertised
signature algorithms in ClientHello and CertificateRequest.

Fixes #25355

Change-Id: I9fdd839afde4fd6b13fcbc5cc7017fd8c35085ee
Reviewed-on: https://go-review.googlesource.com/c/go/+/177698
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>

1 files changed, 49 insertions, 49 deletions

diff --git a/src/crypto/tls/testdata/Client-TLSv12-ClientCert-RSA-ECDSA b/src/crypto/tls/testdata/Client-TLSv12-ClientCert-RSA-ECDSA
index 06a9be85a0..c9d74439f0 100644
--- a/src/crypto/tls/testdata/Client-TLSv12-ClientCert-RSA-ECDSA
+++ b/src/crypto/tls/testdata/Client-TLSv12-ClientCert-RSA-ECDSA
@@ -1,5 +1,5 @@
 >>> Flow 1 (client to server)
-00000000  16 03 01 00 f8 01 00 00  f4 03 03 00 00 00 00 00  |................|
+00000000  16 03 01 00 fa 01 00 00  f6 03 03 00 00 00 00 00  |................|
 00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
 00000020  00 00 00 00 00 00 00 00  00 00 00 20 00 00 00 00  |........... ....|
 00000030  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
@@ -7,20 +7,20 @@
 00000050  cc a9 c0 2f c0 2b c0 30  c0 2c c0 27 c0 13 c0 23  |.../.+.0.,.'...#|
 00000060  c0 09 c0 14 c0 0a 00 9c  00 9d 00 3c 00 2f 00 35  |...........<./.5|
 00000070  c0 12 00 0a 00 05 c0 11  c0 07 13 01 13 03 13 02  |................|
-00000080  01 00 00 79 00 05 00 05  01 00 00 00 00 00 0a 00  |...y............|
+00000080  01 00 00 7b 00 05 00 05  01 00 00 00 00 00 0a 00  |...{............|
 00000090  0a 00 08 00 1d 00 17 00  18 00 19 00 0b 00 02 01  |................|
-000000a0  00 00 0d 00 18 00 16 08  04 08 05 08 06 04 01 04  |................|
-000000b0  03 05 01 05 03 06 01 06  03 02 01 02 03 ff 01 00  |................|
-000000c0  01 00 00 12 00 00 00 2b  00 09 08 03 04 03 03 03  |.......+........|
-000000d0  02 03 01 00 33 00 26 00  24 00 1d 00 20 2f e5 7d  |....3.&.$... /.}|
-000000e0  a3 47 cd 62 43 15 28 da  ac 5f bb 29 07 30 ff f6  |.G.bC.(.._.).0..|
-000000f0  84 af c4 cf c2 ed 90 99  5f 58 cb 3b 74           |........_X.;t|
+000000a0  00 00 0d 00 1a 00 18 08  04 04 03 08 07 08 05 08  |................|
+000000b0  06 04 01 05 01 06 01 05  03 06 03 02 01 02 03 ff  |................|
+000000c0  01 00 01 00 00 12 00 00  00 2b 00 09 08 03 04 03  |.........+......|
+000000d0  03 03 02 03 01 00 33 00  26 00 24 00 1d 00 20 2f  |......3.&.$... /|
+000000e0  e5 7d a3 47 cd 62 43 15  28 da ac 5f bb 29 07 30  |.}.G.bC.(.._.).0|
+000000f0  ff f6 84 af c4 cf c2 ed  90 99 5f 58 cb 3b 74     |.........._X.;t|
 >>> Flow 2 (server to client)
-00000000  16 03 03 00 59 02 00 00  55 03 03 69 98 98 c5 21  |....Y...U..i...!|
-00000010  2e b7 a6 8e ba d1 11 b4  0a 84 ad 33 b9 8c 81 d7  |...........3....|
-00000020  26 ba 77 32 24 e5 c2 95  5f d2 b8 20 23 79 50 e0  |&.w2$..._.. #yP.|
-00000030  59 94 e1 05 47 58 ce a0  52 32 3f 96 1a e5 d8 15  |Y...GX..R2?.....|
-00000040  ec ae c9 51 a1 1c 19 e0  ac 40 28 9d c0 09 00 00  |...Q.....@(.....|
+00000000  16 03 03 00 59 02 00 00  55 03 03 61 3f 7c 9a 87  |....Y...U..a?|..|
+00000010  de 3b 63 d2 7e 08 97 8a  84 d1 78 f0 25 0e d6 cd  |.;c.~.....x.%...|
+00000020  a0 e0 0c 90 e2 63 70 54  5b 3b 11 20 ef dc d6 32  |.....cpT[;. ...2|
+00000030  f4 4f 37 07 e9 75 89 a1  2f 8b ca 8a dd 5c 3d 6c  |.O7..u../....\=l|
+00000040  9c 8b 89 07 38 ac d2 7e  ab 98 b9 e5 c0 09 00 00  |....8..~........|
 00000050  0d ff 01 00 01 00 00 0b  00 04 03 00 01 02 16 03  |................|
 00000060  03 02 0e 0b 00 02 0a 00  02 07 00 02 04 30 82 02  |.............0..|
 00000070  00 30 82 01 62 02 09 00  b8 bf 2d 47 a0 d2 eb f4  |.0..b.....-G....|
@@ -55,18 +55,18 @@
 00000240  13 83 0d 94 06 bb d4 37  7a f6 ec 7a c9 86 2e dd  |.......7z..z....|
 00000250  d7 11 69 7f 85 7c 56 de  fb 31 78 2b e4 c7 78 0d  |..i..|V..1x+..x.|
 00000260  ae cb be 9e 4e 36 24 31  7b 6a 0f 39 95 12 07 8f  |....N6$1{j.9....|
-00000270  2a 16 03 03 00 b7 0c 00  00 b3 03 00 1d 20 b8 1d  |*............ ..|
-00000280  dd 31 88 3e 51 9e d8 b3  7f f0 93 7c 77 70 79 2c  |.1.>Q......|wpy,|
-00000290  cb 21 d3 b8 8d 3d 65 33  2b a0 0d bb 5f 6a 04 03  |.!...=e3+..._j..|
-000002a0  00 8b 30 81 88 02 42 01  50 71 c1 68 9b a3 b3 7f  |..0...B.Pq.h....|
-000002b0  ab 3f b0 32 d8 57 36 db  3f e5 5b 26 36 51 ed 89  |.?.2.W6.?.[&6Q..|
-000002c0  33 a5 e3 e3 49 2b ac d7  b2 9c 3f 6b 4d 8e 21 3d  |3...I+....?kM.!=|
-000002d0  f6 bc 22 af 0a 48 f0 14  ff ed 14 95 16 e3 45 b3  |.."..H........E.|
-000002e0  b3 e7 c2 09 a5 e9 12 a1  4b 02 42 01 35 34 64 1c  |........K.B.54d.|
-000002f0  d3 28 48 66 82 f3 93 8e  36 0b f7 ac ad f7 f5 4f  |.(Hf....6......O|
-00000300  e5 fc b7 a8 a3 f0 fb 28  70 9e 36 bc c3 82 1b 22  |.......(p.6...."|
-00000310  ef 95 ab 70 28 07 0d aa  c0 42 d6 c6 0e ed 37 d7  |...p(....B....7.|
-00000320  a6 a0 75 e6 db 03 b7 3c  61 26 8a 47 e1 16 03 03  |..u....<a&.G....|
+00000270  2a 16 03 03 00 b7 0c 00  00 b3 03 00 1d 20 9e 1c  |*............ ..|
+00000280  a9 0f 8a 83 fb 33 a7 a4  0e 75 9a 96 ba 14 59 26  |.....3...u....Y&|
+00000290  48 ad 94 ad 79 d0 81 f1  b6 39 eb c8 6b 45 04 03  |H...y....9..kE..|
+000002a0  00 8b 30 81 88 02 42 01  49 b1 7a 06 09 c7 41 16  |..0...B.I.z...A.|
+000002b0  65 2f 0b 89 47 2e 53 10  0a 9e 18 c4 c6 39 f8 74  |e/..G.S......9.t|
+000002c0  79 49 e8 45 76 88 78 d7  2b 93 61 4a 78 93 e4 32  |yI.Ev.x.+.aJx..2|
+000002d0  74 57 5f 77 d6 65 de b6  13 50 d5 06 43 40 c3 98  |tW_w.e...P..C@..|
+000002e0  87 7a 8b 90 54 3d 62 fa  7e 02 42 00 aa 6c 3b 6b  |.z..T=b.~.B..l;k|
+000002f0  3f 15 1d 23 ef 50 bf 09  18 65 4b b0 5f 67 ba d9  |?..#.P...eK._g..|
+00000300  c7 dd 1d 26 30 9c 5b 14  50 61 93 da e0 8f 77 82  |...&0.[.Pa....w.|
+00000310  43 6b d0 81 75 96 ac 0e  24 96 54 bf e2 22 a9 4e  |Ck..u...$.T..".N|
+00000320  90 07 de 61 86 f0 a4 09  59 5e d3 e5 3d 16 03 03  |...a....Y^..=...|
 00000330  00 3a 0d 00 00 36 03 01  02 40 00 2e 04 03 05 03  |.:...6...@......|
 00000340  06 03 08 07 08 08 08 09  08 0a 08 0b 08 04 08 05  |................|
 00000350  08 06 04 01 05 01 06 01  03 03 02 03 03 01 02 01  |................|
@@ -108,31 +108,31 @@
 00000200  e5 35 16 03 03 00 25 10  00 00 21 20 2f e5 7d a3  |.5....%...! /.}.|
 00000210  47 cd 62 43 15 28 da ac  5f bb 29 07 30 ff f6 84  |G.bC.(.._.).0...|
 00000220  af c4 cf c2 ed 90 99 5f  58 cb 3b 74 16 03 03 00  |......._X.;t....|
-00000230  88 0f 00 00 84 08 04 00  80 0a f0 58 cc 8a d0 1c  |...........X....|
-00000240  77 22 05 20 40 d3 74 f8  af d9 17 ed 01 61 5e c2  |w". @.t......a^.|
-00000250  9d 3a 53 ce 55 c6 11 9c  63 01 14 97 38 5f d8 17  |.:S.U...c...8_..|
-00000260  68 6f ee 09 73 42 23 dc  40 f8 4a 41 4d ca c8 98  |ho..sB#.@.JAM...|
-00000270  65 09 22 ca cd 27 00 8b  27 36 8a f9 1c 07 7f 3b  |e."..'..'6.....;|
-00000280  98 46 2e fc 50 8e ca 4c  0e 2a f0 c4 e5 87 e2 24  |.F..P..L.*.....$|
-00000290  46 8b 3b 03 d3 03 78 f1  76 f5 14 12 c1 63 f7 21  |F.;...x.v....c.!|
-000002a0  e7 27 17 ce 2d a6 eb 50  ef e4 aa 32 14 89 f4 02  |.'..-..P...2....|
-000002b0  02 b7 9b 47 27 ca 56 5b  32 14 03 03 00 01 01 16  |...G'.V[2.......|
+00000230  88 0f 00 00 84 08 04 00  80 1f 32 e0 7a 18 d4 63  |..........2.z..c|
+00000240  9b a3 30 16 57 2d 0e 13  78 b6 a9 07 90 04 34 7d  |..0.W-..x.....4}|
+00000250  2d e8 db b6 bb 95 07 80  6c 4b 59 d7 47 34 b2 d5  |-.......lKY.G4..|
+00000260  3a 91 87 80 a4 7d bb 9f  f2 dc dc 9e 7c cb cc 53  |:....}......|..S|
+00000270  b2 46 60 3e 27 ab 46 94  03 d2 a8 f6 b3 66 81 b8  |.F`>'.F......f..|
+00000280  13 2d e2 78 c7 1c ad 51  05 77 79 c1 87 b4 0d 1d  |.-.x...Q.wy.....|
+00000290  95 8d 3f 4d a2 61 94 f8  bf 30 84 b4 42 6e 42 b0  |..?M.a...0..BnB.|
+000002a0  aa 73 57 65 86 1e b2 af  c8 4b 03 84 1e 2a 3a f4  |.sWe.....K...*:.|
+000002b0  6e 45 73 9e 65 0a ca 3f  8a 14 03 03 00 01 01 16  |nEs.e..?........|
 000002c0  03 03 00 40 00 00 00 00  00 00 00 00 00 00 00 00  |...@............|
-000002d0  00 00 00 00 5e ab 60 05  38 88 e6 d3 ba fd 13 2a  |....^.`.8......*|
-000002e0  8a 17 c8 6e 54 d4 4e fd  c4 12 87 c4 20 ef de 62  |...nT.N..... ..b|
-000002f0  fd d3 50 6f 5f 6b 9d b2  00 aa 5a ab 2c d1 3d 39  |..Po_k....Z.,.=9|
-00000300  46 20 ab d7                                       |F ..|
+000002d0  00 00 00 00 ae b6 dd 09  5d ec ff 1c 09 88 eb a4  |........].......|
+000002e0  be c2 76 48 0c f0 7b 6f  50 f8 52 f9 81 97 28 aa  |..vH..{oP.R...(.|
+000002f0  31 31 91 ea 98 80 50 55  e0 71 9b 82 9b e8 48 ec  |11....PU.q....H.|
+00000300  3d 45 c3 f2                                       |=E..|
 >>> Flow 4 (server to client)
-00000000  14 03 03 00 01 01 16 03  03 00 40 d7 80 4d 81 26  |..........@..M.&|
-00000010  8f 46 5b b4 63 56 cd bd  a6 ca 31 ba 8e b8 5b a2  |.F[.cV....1...[.|
-00000020  47 a3 ef 5f ca a2 6a af  d2 2c f9 bb c9 1b 20 fc  |G.._..j..,.... .|
-00000030  a1 78 ca 7e 79 09 66 08  2c cb 0c a5 a3 35 01 ed  |.x.~y.f.,....5..|
-00000040  90 90 3d 32 f3 7b 30 25  ca 5c 66                 |..=2.{0%.\f|
+00000000  14 03 03 00 01 01 16 03  03 00 40 ca 5e 0f 47 25  |..........@.^.G%|
+00000010  5c a6 64 4d 90 74 ba d2  0b e8 df 3b cf 43 9a a7  |\.dM.t.....;.C..|
+00000020  95 28 d2 a6 0c 27 0f a9  d0 bf 11 c1 52 52 04 32  |.(...'......RR.2|
+00000030  14 9d 4a a1 35 3b 1d 5c  84 b5 72 79 5a fc 4c c9  |..J.5;.\..ryZ.L.|
+00000040  68 ca 64 9f b1 d9 ed 0b  98 66 53                 |h.d......fS|
 >>> Flow 5 (client to server)
 00000000  17 03 03 00 30 00 00 00  00 00 00 00 00 00 00 00  |....0...........|
-00000010  00 00 00 00 00 58 dc 0e  2b 4a 58 05 aa 22 cb 21  |.....X..+JX..".!|
-00000020  1c 6b 93 40 ab 6b 99 aa  ae c0 e0 f8 31 22 a3 1b  |.k.@.k......1"..|
-00000030  4a 98 bc 70 08 15 03 03  00 30 00 00 00 00 00 00  |J..p.....0......|
-00000040  00 00 00 00 00 00 00 00  00 00 8a 7b b8 60 83 23  |...........{.`.#|
-00000050  53 04 cf 14 b7 cf a9 d8  70 51 fe 92 f3 9c 25 6a  |S.......pQ....%j|
-00000060  bf 43 e0 bd ca 33 33 6c  30 dc                    |.C...33l0.|
+00000010  00 00 00 00 00 b8 30 3e  37 f6 8f 50 8b 97 78 81  |......0>7..P..x.|
+00000020  aa 53 ab 4d 44 a4 0a d7  3c 49 7f 59 33 b5 0e 22  |.S.MD...<I.Y3.."|
+00000030  c8 fd c6 70 dc 15 03 03  00 30 00 00 00 00 00 00  |...p.....0......|
+00000040  00 00 00 00 00 00 00 00  00 00 dc 74 fa 86 b9 66  |...........t...f|
+00000050  eb 0b 2e ef 57 b0 09 95  31 e6 8a 06 de 93 f7 7f  |....W...1.......|
+00000060  46 f1 7d b8 e3 16 fa 68  13 60                    |F.}....h.`|