diff options
| author | Russ Cox <rsc@golang.org> | 2015-02-06 16:57:38 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2015-02-11 19:18:17 +0000 |
| commit | fbd17986ea386cfcfb5c8ced43ef3f429825cc1a (patch) | |
| tree | 7b372a10b17581c5ceb2e296ed0c01e911a56113 /src/cmd | |
| parent | e90a91eac4e493536aeeff867a2406c0ab31c76d (diff) | |
| download | go-fbd17986ea386cfcfb5c8ced43ef3f429825cc1a.tar.xz | |
[dev.cc] liblink: fix printing of SHRL CX, DX:AX
Change-Id: I6a119109c8dea7fecb32de2c4b1b5ba54bc485be
Reviewed-on: https://go-review.googlesource.com/4100
Reviewed-by: Rob Pike <r@golang.org>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/internal/obj/i386/list8.go | 22 | ||||
| -rw-r--r-- | src/cmd/internal/obj/x86/list6.go | 14 |
2 files changed, 12 insertions, 24 deletions
diff --git a/src/cmd/internal/obj/i386/list8.go b/src/cmd/internal/obj/i386/list8.go index 087da7e4d0..33dfea44ad 100644 --- a/src/cmd/internal/obj/i386/list8.go +++ b/src/cmd/internal/obj/i386/list8.go @@ -59,6 +59,12 @@ func Pconv(p *obj.Prog) string { default: str = fmt.Sprintf("%.5d (%v)\t%v\t%v,%v", p.Pc, p.Line(), Aconv(int(p.As)), Dconv(p, 0, &p.From), Dconv(p, 0, &p.To)) + // TODO(rsc): This special case is for SHRQ $32, AX:DX, which encodes as + // SHRQ $32(DX*0), AX + // Remove. + if (p.From.Type == obj.TYPE_REG || p.From.Type == obj.TYPE_CONST) && p.From.Index != 0 { + str += fmt.Sprintf(":%s", Rconv(int(p.From.Index))) + } break } @@ -97,14 +103,6 @@ func Dconv(p *obj.Prog, flag int, a *obj.Addr) string { str = fmt.Sprintf("%v", Rconv(int(a.Reg))) - // TODO(rsc): This special case is for SHRQ $32, AX:DX, which encodes as - // SHRQ $32(DX*0), AX - // Remove. - if a.Index != REG_NONE { - s = fmt.Sprintf("(%v*%d)", Rconv(int(a.Index)), int(a.Scale)) - str += s - } - case obj.TYPE_BRANCH: if a.Sym != nil { str = fmt.Sprintf("%s(SB)", a.Sym.Name) @@ -158,14 +156,6 @@ func Dconv(p *obj.Prog, flag int, a *obj.Addr) string { case obj.TYPE_CONST: str = fmt.Sprintf("$%d", a.Offset) - // TODO(rsc): This special case is for SHRQ $32, AX:DX, which encodes as - // SHRQ $32(DX*0), AX - // Remove. - if a.Index != REG_NONE { - s = fmt.Sprintf("(%v*%d)", Rconv(int(a.Index)), int(a.Scale)) - str += s - } - case obj.TYPE_TEXTSIZE: if a.U.Argsize == obj.ArgsSizeUnknown { str = fmt.Sprintf("$%d", a.Offset) diff --git a/src/cmd/internal/obj/x86/list6.go b/src/cmd/internal/obj/x86/list6.go index c782f6387a..af10f38ef0 100644 --- a/src/cmd/internal/obj/x86/list6.go +++ b/src/cmd/internal/obj/x86/list6.go @@ -71,6 +71,12 @@ func Pconv(p *obj.Prog) string { default: str = fmt.Sprintf("%.5d (%v)\t%v\t%v,%v", p.Pc, p.Line(), Aconv(int(p.As)), Dconv(p, 0, &p.From), Dconv(p, 0, &p.To)) + // TODO(rsc): This special case is for SHRQ $32, AX:DX, which encodes as + // SHRQ $32(DX*0), AX + // Remove. + if (p.From.Type == obj.TYPE_REG || p.From.Type == obj.TYPE_CONST) && p.From.Index != 0 { + str += fmt.Sprintf(":%s", Rconv(int(p.From.Index))) + } break } @@ -162,14 +168,6 @@ func Dconv(p *obj.Prog, flag int, a *obj.Addr) string { case obj.TYPE_CONST: str = fmt.Sprintf("$%d", a.Offset) - // TODO(rsc): This special case is for SHRQ $32, AX:DX, which encodes as - // SHRQ $32(DX*0), AX - // Remove. - if a.Index != REG_NONE { - s = fmt.Sprintf("(%v*%d)", Rconv(int(a.Index)), int(a.Scale)) - str += s - } - case obj.TYPE_TEXTSIZE: if a.U.Argsize == obj.ArgsSizeUnknown { str = fmt.Sprintf("$%d", a.Offset) |