diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2014-08-19 18:45:05 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2014-08-19 18:45:05 -0700 |
| commit | e38fa9164894b2610a41b335a56e3b6494a3cef6 (patch) | |
| tree | ccceef2bb43ee1e7a16654dd1a4a2828b140afda /src/cmd | |
| parent | 339a24da6611487308b497a2ba7506c5451c637f (diff) | |
| download | go-e38fa9164894b2610a41b335a56e3b6494a3cef6.tar.xz | |
net/http: fix TimeoutHandler data races; hold lock longer
The existing lock needed to be held longer. If a timeout occured
while writing (but after the guarded timeout check), the writes
would clobber a future connection's buffer.
Also remove a harmless warning by making Write also set the
flag that headers were sent (implicitly), so we don't try to
write headers later (a no-op + warning) on timeout after we've
started writing.
Fixes #8414
Fixes #8209
LGTM=ruiu, adg
R=adg, ruiu
CC=golang-codereviews
https://golang.org/cl/123610043
Diffstat (limited to 'src/cmd')
0 files changed, 0 insertions, 0 deletions
