diff options
| author | Cherry Mui <cherryyz@google.com> | 2026-03-25 14:30:11 -0400 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2026-03-27 16:17:55 -0700 |
| commit | c7238e81ca45af755a2c7770950eb163efa3495f (patch) | |
| tree | 4e150b5967c2ea8cbea823e1a316f656b4841328 /src/cmd | |
| parent | 733122c7cdff477f797fd8fd92524665a80b0852 (diff) | |
| download | go-c7238e81ca45af755a2c7770950eb163efa3495f.tar.xz | |
cmd/link: run TestMachOBuildVersion only on darwin
There is no need to cross build a Mach-O binary in order to test
this. Only run it on Mach-O platforms. Also just do native build
instead of forcing GOARCH=amd64.
For #78266.
Change-Id: I7603ba9a51ea4f13411fdb4e159709f981ee755d
Reviewed-on: https://go-review.googlesource.com/c/go/+/759260
TryBot-Bypass: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/link/link_test.go | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go index 354442a2f9..ac9a7a90b9 100644 --- a/src/cmd/link/link_test.go +++ b/src/cmd/link/link_test.go @@ -451,7 +451,9 @@ func main() { } func TestMachOBuildVersion(t *testing.T) { testenv.MustHaveGoBuild(t) - + if runtime.GOOS != "darwin" { + t.Skip("skip on non-Mach-O platforms") + } t.Parallel() tmpdir := t.TempDir() @@ -464,11 +466,7 @@ func TestMachOBuildVersion(t *testing.T) { exe := filepath.Join(tmpdir, "main") cmd := goCmd(t, "build", "-ldflags=-linkmode=internal", "-o", exe, src) - cmd.Env = append(cmd.Env, - "CGO_ENABLED=0", - "GOOS=darwin", - "GOARCH=amd64", - ) + cmd.Env = append(cmd.Env, "CGO_ENABLED=0") if out, err := cmd.CombinedOutput(); err != nil { t.Fatalf("%v: %v:\n%s", cmd.Args, err, out) } |