aboutsummaryrefslogtreecommitdiff
path: root/src/cmd
diff options
context:
space:
mode:
authorMark Ryan <markdryan@rivosinc.com>2024-12-11 18:09:32 +0100
committerMeng Zhuo <mengzhuo1203@gmail.com>2025-03-20 21:24:28 -0700
commitc386ed107e65f495acb6aacb0efcaade27da6a15 (patch)
treef5addee08e004ea2748e3328c2ee4d38390adcff /src/cmd
parentc558f017ef2a98fd625107d36271e184ae29c626 (diff)
downloadgo-c386ed107e65f495acb6aacb0efcaade27da6a15.tar.xz
cmd/internal/obj/riscv: fix the encoding for REV8 and ORCB
The instructions are currently encoded and validated using an iIIEncoding which is incorrect as these instructions do not take an immediate operand. Encode them instead using an rIIEncoding as is done for the other two register argument bitmanip instructions. Change-Id: Ia4d9c6f6ebd2dfc381935ebc11afa8fc3664232b Reviewed-on: https://go-review.googlesource.com/c/go/+/637317 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Joel Sing <joel@sing.id.au> Reviewed-by: Meng Zhuo <mengzhuo1203@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/cmd')
-rw-r--r--src/cmd/internal/obj/riscv/obj.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/internal/obj/riscv/obj.go b/src/cmd/internal/obj/riscv/obj.go
index f9ae5fe677..d3b6857a75 100644
--- a/src/cmd/internal/obj/riscv/obj.go
+++ b/src/cmd/internal/obj/riscv/obj.go
@@ -2094,8 +2094,8 @@ var instructions = [ALAST & obj.AMask]instructionData{
ARORI & obj.AMask: {enc: iIIEncoding, ternary: true},
ARORIW & obj.AMask: {enc: iIIEncoding, ternary: true},
ARORW & obj.AMask: {enc: rIIIEncoding, immForm: ARORIW, ternary: true},
- AORCB & obj.AMask: {enc: iIIEncoding},
- AREV8 & obj.AMask: {enc: iIIEncoding},
+ AORCB & obj.AMask: {enc: rIIEncoding},
+ AREV8 & obj.AMask: {enc: rIIEncoding},
// 28.4.4: Single-bit Instructions (Zbs)
ABCLR & obj.AMask: {enc: rIIIEncoding, immForm: ABCLRI, ternary: true},