aboutsummaryrefslogtreecommitdiff
path: root/src/cmd
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2021-02-15 09:25:55 -0500
committerRuss Cox <rsc@golang.org>2021-02-19 00:02:23 +0000
commitaa0388f2ed937669e9f938da8a65c75ea144ebfd (patch)
tree511a009cdb84a169c59d4f486a6791616aa7a19d /src/cmd
parent6fe8981620aa61cb43476538f8230231623f9e13 (diff)
downloadgo-aa0388f2ed937669e9f938da8a65c75ea144ebfd.tar.xz
runtime: remove unnecessary writes to gp.sched.g
A g's sched.g is set in newproc1: newg.sched.g = guintptr(unsafe.Pointer(newg)) After that, it never changes. Yet lots of assembly code does "g.sched.g = g" unnecessarily. Remove all those lines to avoid confusion about whether it ever changes. Also, split gogo into two functions, one that does the nil g check and a second that does the actual switch. This way, if the nil g check fails, we get a stack trace showing the call stack that led to the failure. (The SP write would otherwise cause the stack trace to abort.) Also restore the proper nil g check in a handful of assembly functions. (There is little point in checking for nil g *after* installing it as the real g.) Change-Id: I22866b093f901f765de1d074e36eeec10366abfb Reviewed-on: https://go-review.googlesource.com/c/go/+/292109 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd')
0 files changed, 0 insertions, 0 deletions