diff options
| author | Bryan C. Mills <bcmills@google.com> | 2020-03-05 11:14:25 -0500 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2020-03-05 21:42:20 +0000 |
| commit | 4a70ff425b3c16c19785b04bb89ca856749ed65b (patch) | |
| tree | cb6263019744b47c7f93664bc67a81db82c27922 /src/cmd | |
| parent | 55d4cbfbe10c11e56e1642cbb6b108eaf2620e09 (diff) | |
| download | go-4a70ff425b3c16c19785b04bb89ca856749ed65b.tar.xz | |
cmd/go/internal/renameio: skip test affected by kernel bug on macOS 10.14 builders
The test will remain flaky on the -nocgo builder until #37695 is addressed.
Updates #37695
Fixes #33041
Change-Id: I5d661ef39e82ab1dce3a76e0e4059cf556135e89
Reviewed-on: https://go-review.googlesource.com/c/go/+/222158
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/go/internal/renameio/renameio_test.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/cmd/go/internal/renameio/renameio_test.go b/src/cmd/go/internal/renameio/renameio_test.go index ee2f3ba1bb..df8ddabdb8 100644 --- a/src/cmd/go/internal/renameio/renameio_test.go +++ b/src/cmd/go/internal/renameio/renameio_test.go @@ -9,11 +9,13 @@ package renameio import ( "encoding/binary" "errors" + "internal/testenv" "io/ioutil" "math/rand" "os" "path/filepath" "runtime" + "strings" "sync" "sync/atomic" "syscall" @@ -24,6 +26,10 @@ import ( ) func TestConcurrentReadsAndWrites(t *testing.T) { + if runtime.GOOS == "darwin" && strings.HasSuffix(testenv.Builder(), "-10_14") { + testenv.SkipFlaky(t, 33041) + } + dir, err := ioutil.TempDir("", "renameio") if err != nil { t.Fatal(err) |