diff options
| author | Jeff Wendling <jeff@spacemonkey.com> | 2017-04-06 15:45:30 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-04-06 17:39:20 +0000 |
| commit | 168eb9cf3395583541224af0227c19ddb13e35be (patch) | |
| tree | c5639d2266e6fcb4d9dfdfbe9f819c2d5cb42b54 /src/cmd | |
| parent | 4e7724b2db4163f88a542fa0ff0dc72dfc5698de (diff) | |
| download | go-168eb9cf3395583541224af0227c19ddb13e35be.tar.xz | |
cmd/dist: disable plugin test on linux-arm with GOARM=5
Plugin support is patchy at the moment, so disable the test for
now until the test can be fixed. This way, we can get builders
for ARMv5 running for the rest of the code.
Updates #19674
Change-Id: I08aa211c08a85688656afe2ad2e680a2a6e5dfac
Reviewed-on: https://go-review.googlesource.com/39716
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/dist/test.go | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 73e99324db..9ba7798069 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -59,6 +59,7 @@ type tester struct { goroot string goarch string gohostarch string + goarm string goos string gohostos string cgoEnabled bool @@ -102,6 +103,7 @@ func (t *tester) run() { t.gohostos = mustEnv("GOHOSTOS") t.goarch = mustEnv("GOARCH") t.gohostarch = mustEnv("GOHOSTARCH") + t.goarm = os.Getenv("GOARM") slurp, err := exec.Command("go", "env", "CGO_ENABLED").Output() if err != nil { log.Fatalf("Error running go env CGO_ENABLED: %v", err) @@ -782,6 +784,12 @@ func (t *tester) supportedBuildmode(mode string) bool { return false } + if pair == "linux-arm" && t.goarm == "5" { + // Skip the plugin tests for now on ARMv5 because it causes a + // SIGILL. See https://golang.org/issue/19674 + return false + } + // linux-arm64 is missing because it causes the external linker // to crash, see https://golang.org/issue/17138 switch pair { |