diff options
| author | Todd Neal <todd@tneal.org> | 2017-04-24 11:20:09 -0400 |
|---|---|---|
| committer | Todd Neal <todd@tneal.org> | 2017-05-09 23:22:00 +0000 |
| commit | 08dca4c649ba7f90f209376ba342bd46ef14ebe5 (patch) | |
| tree | e9c7367c8a8830550312b74b773068240bd3e384 /src/cmd | |
| parent | 46b88c9fbccad489aed53a77afa680792fff6eaa (diff) | |
| download | go-08dca4c649ba7f90f209376ba342bd46ef14ebe5.tar.xz | |
cmd/compile: ignore types when considering tuple select for CSE
Fixes #20097
Change-Id: I3c9626ccc8cd0c46a7081ea8650b2ff07a5d4fcd
Reviewed-on: https://go-review.googlesource.com/41505
Run-TryBot: Todd Neal <todd@tneal.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/compile/internal/ssa/cse.go | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/src/cmd/compile/internal/ssa/cse.go b/src/cmd/compile/internal/ssa/cse.go index d852e22d5c..d931d6bf5f 100644 --- a/src/cmd/compile/internal/ssa/cse.go +++ b/src/cmd/compile/internal/ssa/cse.go @@ -322,9 +322,13 @@ func cmpVal(v, w *Value, auxIDs auxmap) types.Cmp { // that generate memory. return lt2Cmp(v.ID < w.ID) } - - if tc := v.Type.Compare(w.Type); tc != types.CMPeq { - return tc + // OpSelect is a pseudo-op. We need to be more agressive + // regarding CSE to keep multiple OpSelect's of the same + // argument from existing. + if v.Op != OpSelect0 && v.Op != OpSelect1 { + if tc := v.Type.Compare(w.Type); tc != types.CMPeq { + return tc + } } if v.Aux != w.Aux { |