diff options
| author | Cherry Mui <cherryyz@google.com> | 2024-05-15 14:52:35 -0400 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2024-05-17 16:59:50 +0000 |
| commit | 003683f41d667c8942657d6fd8bbf9e7c6925c87 (patch) | |
| tree | fedba2d380488ea09400fb7ff69235636e32d9c2 /src/cmd | |
| parent | 41aab30bd260297ad8ddad47e98fdf8390a9a67e (diff) | |
| download | go-003683f41d667c8942657d6fd8bbf9e7c6925c87.tar.xz | |
cmd/link: enable checklinkname by default
Fixes #67401.
Change-Id: Ia8e091c77414cd1281cadc524215ef89ba9184b2
Reviewed-on: https://go-review.googlesource.com/c/go/+/585556
Reviewed-by: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/link/internal/ld/main.go | 2 | ||||
| -rw-r--r-- | src/cmd/link/link_test.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/link/internal/ld/main.go b/src/cmd/link/internal/ld/main.go index e6608fd791..9f50ad183a 100644 --- a/src/cmd/link/internal/ld/main.go +++ b/src/cmd/link/internal/ld/main.go @@ -96,7 +96,7 @@ var ( FlagS = flag.Bool("s", false, "disable symbol table") flag8 bool // use 64-bit addresses in symbol table flagInterpreter = flag.String("I", "", "use `linker` as ELF dynamic linker") - flagCheckLinkname = flag.Bool("checklinkname", false, "check linkname symbol references") + flagCheckLinkname = flag.Bool("checklinkname", true, "check linkname symbol references") FlagDebugTramp = flag.Int("debugtramp", 0, "debug trampolines") FlagDebugTextSize = flag.Int("debugtextsize", 0, "debug text section max size") flagDebugNosplit = flag.Bool("debugnosplit", false, "dump nosplit call graph") diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go index e33494f7f1..ea377e77cc 100644 --- a/src/cmd/link/link_test.go +++ b/src/cmd/link/link_test.go @@ -1448,7 +1448,7 @@ func TestCheckLinkname(t *testing.T) { t.Parallel() src := filepath.Join("testdata", "linkname", test.src) exe := filepath.Join(tmpdir, test.src+".exe") - cmd := testenv.Command(t, testenv.GoToolPath(t), "build", "-ldflags=-checklinkname=1", "-o", exe, src) + cmd := testenv.Command(t, testenv.GoToolPath(t), "build", "-o", exe, src) out, err := cmd.CombinedOutput() if test.ok && err != nil { t.Errorf("build failed unexpectedly: %v:\n%s", err, out) |