diff options
| author | Elias Naur <elias.naur@gmail.com> | 2018-01-21 12:16:49 +0100 |
|---|---|---|
| committer | Elias Naur <elias.naur@gmail.com> | 2018-01-22 16:53:10 +0000 |
| commit | 40ea396c0975c7a52feb1c8291d38762c774897f (patch) | |
| tree | eb199a17ed389eebba46fa65b04716a17a74ef76 /src/cmd/vendor/github.com/google | |
| parent | 0133b5df6095669bf22eda5e8d74087f036b39f8 (diff) | |
| download | go-40ea396c0975c7a52feb1c8291d38762c774897f.tar.xz | |
cmd/vendor/github.com/google/pprof/internal/driver: skip read only dir error on Android
On an android/amd64 emulator, $HOME points to / which is not writable.
Ignore the error in the pprof driver test.
With this, androidtest.sh on android/amd64 and android/386 passes.
Upstream pull request https://github.com/google/pprof/pull/295.
Change-Id: If919d7f44530a977fd044631ad01bac87d32deaa
Reviewed-on: https://go-review.googlesource.com/88817
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Diffstat (limited to 'src/cmd/vendor/github.com/google')
| -rw-r--r-- | src/cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go b/src/cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go index 5bcd40daa7..32af2e9b20 100644 --- a/src/cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go +++ b/src/cmd/vendor/github.com/google/pprof/internal/driver/fetch_test.go @@ -412,8 +412,10 @@ func TestHttpsInsecure(t *testing.T) { Symbolize: "remote", } rx := "Saved profile in" - if runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64") { + if runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64") || + runtime.GOOS == "android" { // On iOS, $HOME points to the app root directory and is not writable. + // On Android, $HOME points to / which is not writable. rx += "|Could not use temp dir" } o := &plugin.Options{ |