diff options
| author | Keith Randall <khr@google.com> | 2019-03-11 10:57:44 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2019-03-11 19:18:03 +0000 |
| commit | 486ca37b14f56b2e125fc3afbd900a5369532043 (patch) | |
| tree | 270e498fed688e1c2fc6ac40a790e6482a6e5a52 /src/cmd/vendor/github.com/google/pprof/profile/testdata/java.contention.string | |
| parent | ac56baa09f789ab93dd97b31c4f033da7c85a6a4 (diff) | |
| download | go-486ca37b14f56b2e125fc3afbd900a5369532043.tar.xz | |
test: fix memcombine tests
Two tests (load_le_byte8_uint64_inv and load_be_byte8_uint64)
pass but the generated code isn't actually correct.
The test regexp provides a false negative, as it matches the
MOVQ (SP), BP instruction in the epilogue.
Combined loads never worked for these cases - the test was added in error
as part of a batch and not noticed because of the above false match.
Normalize the amd64/386 tests to always negative match on narrower
loads and OR.
Change-Id: I256861924774d39db0e65723866c81df5ab5076f
Reviewed-on: https://go-review.googlesource.com/c/go/+/166837
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/cmd/vendor/github.com/google/pprof/profile/testdata/java.contention.string')
0 files changed, 0 insertions, 0 deletions