diff options
| author | Alberto Donizetti <alb.donizetti@gmail.com> | 2021-05-07 19:10:28 +0200 |
|---|---|---|
| committer | Alberto Donizetti <alb.donizetti@gmail.com> | 2021-05-08 14:59:49 +0000 |
| commit | 68327e1aa11457cd570bc7eaf03a0260950f27d9 (patch) | |
| tree | 998e9b0c2b3a08f582555c4039217a982384dde9 /src/cmd/vendor/github.com/google/pprof/internal/plugin | |
| parent | 4c8f48ed4f3db0e3ba376e6b7a261d26b41d8dd0 (diff) | |
| download | go-68327e1aa11457cd570bc7eaf03a0260950f27d9.tar.xz | |
cmd/vendor: upgrade pprof to latest
This change upgrades the vendored pprof to pick up the fix for a
serious issue that made the source view in browser mode blank
(tracked upstream as google/pprof#621).
I also had to patch pprof.go, since one of the upstream commit we
included introduced a breaking change in the file interface (the Base
method is now called ObjAddr and has a different signature).
I've manually verified that the upgrade fixes the aforementioned
issues with the source view.
Fixes #45786
Change-Id: I00659ae539a2ad603758e1f06572374d483b9ddc
Reviewed-on: https://go-review.googlesource.com/c/go/+/318049
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/cmd/vendor/github.com/google/pprof/internal/plugin')
| -rw-r--r-- | src/cmd/vendor/github.com/google/pprof/internal/plugin/plugin.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/cmd/vendor/github.com/google/pprof/internal/plugin/plugin.go b/src/cmd/vendor/github.com/google/pprof/internal/plugin/plugin.go index 3a8d0af730..a57a0b20a9 100644 --- a/src/cmd/vendor/github.com/google/pprof/internal/plugin/plugin.go +++ b/src/cmd/vendor/github.com/google/pprof/internal/plugin/plugin.go @@ -131,8 +131,9 @@ type ObjFile interface { // Name returns the underlyinf file name, if available Name() string - // Base returns the base address to use when looking up symbols in the file. - Base() uint64 + // ObjAddr returns the objdump (linker) address corresponding to a runtime + // address, and an error. + ObjAddr(addr uint64) (uint64, error) // BuildID returns the GNU build ID of the file, or an empty string. BuildID() string |