diff options
| author | Bryan C. Mills <bcmills@google.com> | 2023-03-01 13:45:18 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-03-10 20:38:29 +0000 |
| commit | d12fe60004ae5e4024c8a93f4f7de7183bb61576 (patch) | |
| tree | 1f3e0ac455b4f30cb9699dcec94f939b2708f6c0 /src/cmd/pprof | |
| parent | 2cbab4e98c6091f5fb6cb73bdebfe328793da388 (diff) | |
| download | go-d12fe60004ae5e4024c8a93f4f7de7183bb61576.tar.xz | |
all: skip tests that fail on android/arm64
Many of the tests skipped platforms that build PIE binaries by
default, but (still) lack a central function to report which platforms
those are.
Some of the tests assumed (but did not check for) internal linking
support, or invoked `go tool link` directly without properly
configuring the external linker.
A few of the tests seem to be triggering latent bugs in the linker.
For #58806.
For #58807.
For #58794.
Change-Id: Ie4d06b1597f404590ad2abf978d4c363647407ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/472455
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/pprof')
| -rw-r--r-- | src/cmd/pprof/pprof_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/cmd/pprof/pprof_test.go b/src/cmd/pprof/pprof_test.go index 353781ac04..d6ca0e28da 100644 --- a/src/cmd/pprof/pprof_test.go +++ b/src/cmd/pprof/pprof_test.go @@ -75,7 +75,11 @@ func mustHaveDisasm(t *testing.T) { } // Skip PIE platforms, pprof can't disassemble PIE. - if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" { + // + // TODO(#58807): factor this condition out into a function in + // internal/platform so that it won't get out of sync with cmd/go and + // cmd/link. + if (runtime.GOOS == "darwin" && runtime.GOARCH == "arm64") || runtime.GOOS == "android" { t.Skipf("skipping on %s/%s, issue 46639", runtime.GOOS, runtime.GOARCH) } } |