diff options
| author | Russ Cox <rsc@golang.org> | 2014-05-14 17:45:13 -0700 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-05-14 17:45:13 -0700 |
| commit | 8e22903b46aadd6eda937417cba86b528cba92e2 (patch) | |
| tree | 4191024da4129525a65e80f28bd2f1e84cef7ca1 /src/cmd/nm | |
| parent | bf1d400d1c75985354f52f7969ba15fb228aacb2 (diff) | |
| download | go-8e22903b46aadd6eda937417cba86b528cba92e2.tar.xz | |
cmd/nm, cmd/objdump: fix elf symbol types
Turns out elf.File.Sections is indexed by the actual
section number, not the number minus one.
I don't know why I thought the -1 was necessary.
Fixes objdump test (and therefore build) on ELF systems.
While we're here, fix bounds on gnuDump so that we
don't crash when asked to disassemble outside
the text segment. May fix Windows build or at least
make the failure more interesting.
TBR=iant
CC=golang-codereviews
https://golang.org/cl/92390043
Diffstat (limited to 'src/cmd/nm')
| -rw-r--r-- | src/cmd/nm/elf.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/nm/elf.go b/src/cmd/nm/elf.go index 58a4b556f3..5aaa194dd1 100644 --- a/src/cmd/nm/elf.go +++ b/src/cmd/nm/elf.go @@ -34,10 +34,10 @@ func elfSymbols(f *os.File) []Sym { sym.Code = 'B' default: i := int(s.Section) - if i <= 0 || i > len(p.Sections) { + if i < 0 || i >= len(p.Sections) { break } - sect := p.Sections[i-1] + sect := p.Sections[i] switch sect.Flags & (elf.SHF_WRITE | elf.SHF_ALLOC | elf.SHF_EXECINSTR) { case elf.SHF_ALLOC | elf.SHF_EXECINSTR: sym.Code = 'T' |