diff options
| author | Than McIntosh <thanm@google.com> | 2022-12-12 11:04:05 -0500 |
|---|---|---|
| committer | Than McIntosh <thanm@google.com> | 2023-01-31 15:09:24 +0000 |
| commit | 066b780502c8c87c03f8a5e0bbc16c1c87221cf1 (patch) | |
| tree | a9ee127b82982cdee487fdfd499defe6c56e66ff /src/cmd/link | |
| parent | da0c375c571037ec5ea6f8ef2be8f07593b40eb6 (diff) | |
| download | go-066b780502c8c87c03f8a5e0bbc16c1c87221cf1.tar.xz | |
cmd/link: load host archive libc_nonshared.a for -fstack-protector
For internal linking, at the point where we finish reading libgcc.a,
if the symbol "__stack_chk_local" is still undefined, then read
in the host archive libc_nonshared.a as well.
Updates #57261.
Change-Id: I0b1e485aa50aa7940db8cabcb3b9a7959bf99ce7
Reviewed-on: https://go-review.googlesource.com/c/go/+/456856
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/link')
| -rw-r--r-- | src/cmd/link/internal/ld/lib.go | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index 3b34e40358..17df56f4d5 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -630,6 +630,25 @@ func (ctxt *Link) loadlib() { } if *flagLibGCC != "none" { hostArchive(ctxt, *flagLibGCC) + // For glibc systems, the linker setup used by GCC + // looks like + // + // GROUP ( /lib/x86_64-linux-gnu/libc.so.6 + // /usr/lib/x86_64-linux-gnu/libc_nonshared.a + // AS_NEEDED ( /lib64/ld-linux-x86-64.so.2 ) ) + // + // where libc_nonshared.a contains a small set of + // symbols including "__stack_chk_fail_local" and a + // few others. Thus if we are doing internal linking + // and "__stack_chk_fail_local" is unresolved (most + // likely due to the use of -fstack-protector), try + // loading libc_nonshared.a to resolve it. + isunresolved := symbolsAreUnresolved(ctxt, []string{"__stack_chk_fail_local"}) + if isunresolved[0] { + if p := ctxt.findLibPath("libc_nonshared.a"); p != "none" { + hostArchive(ctxt, p) + } + } } } } |