diff options
| author | Than McIntosh <thanm@google.com> | 2020-04-07 08:01:24 -0400 |
|---|---|---|
| committer | Than McIntosh <thanm@google.com> | 2020-04-07 13:56:41 +0000 |
| commit | 9f6a35660d4e56d1b9c0922e6c6b9626c3fb25ee (patch) | |
| tree | a957837fdf6e56e7483210a94581f5fb7ab73fba /src/cmd/link/internal/loader | |
| parent | c8d89ddb18bc4ad025ceb24dffa9e0f5630c4128 (diff) | |
| download | go-9f6a35660d4e56d1b9c0922e6c6b9626c3fb25ee.tar.xz | |
[dev.link] cmd/link/internal/loader: speed up Loader.RelocVariant
Remove some extra sanity-checking code from the loader's RelocVariant
method, since it was yielding a slowdown of 1-2% linking kubernetes
hyperkube (once again a reminder that relocation processing is a very
performance-sensitive part of the linker).
Change-Id: Ifbc0662f3f96c5f54131103ce6f7439ecfb9b9dc
Reviewed-on: https://go-review.googlesource.com/c/go/+/227477
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Diffstat (limited to 'src/cmd/link/internal/loader')
| -rw-r--r-- | src/cmd/link/internal/loader/loader.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/cmd/link/internal/loader/loader.go b/src/cmd/link/internal/loader/loader.go index fdc020dd2a..acce23c0c2 100644 --- a/src/cmd/link/internal/loader/loader.go +++ b/src/cmd/link/internal/loader/loader.go @@ -2593,9 +2593,6 @@ func (l *Loader) SetRelocVariant(s Sym, ri int, v sym.RelocVariant) { // RelocVariant returns the 'variant' property of a relocation on // some specific symbol. func (l *Loader) RelocVariant(s Sym, ri int) sym.RelocVariant { - if relocs := l.Relocs(s); ri >= relocs.Count() { - panic("invalid relocation ID") - } return l.relocVariant[relocId{s, ri}] } |