diff options
| author | Cherry Mui <cherryyz@google.com> | 2023-05-04 17:09:49 -0400 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2023-05-05 19:20:01 +0000 |
| commit | f90bb8a38f2f1ed2109f8fa88fb90a5c2db1f3fe (patch) | |
| tree | cece8ec0b7f198ee24034f36848dee831a131211 /src/cmd/link/internal/loader/loader_test.go | |
| parent | 26899ef3ee7cd3d9e663e6f792c93bb411c863db (diff) | |
| download | go-f90bb8a38f2f1ed2109f8fa88fb90a5c2db1f3fe.tar.xz | |
cmd/link: remove elfsetstring out of the loader
Currently, we pass elfsetstring to the loader as a callback, for
a special case of Addstring. This is only used for ELF when adding
strings to the section header string table. Move the logic to the
caller instead, so the loader would not have this special case.
Change-Id: Icfb91f380fe4ba435985c3019681597932f58242
Reviewed-on: https://go-review.googlesource.com/c/go/+/492718
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/cmd/link/internal/loader/loader_test.go')
| -rw-r--r-- | src/cmd/link/internal/loader/loader_test.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/cmd/link/internal/loader/loader_test.go b/src/cmd/link/internal/loader/loader_test.go index 8ee4be033b..32ff2586ce 100644 --- a/src/cmd/link/internal/loader/loader_test.go +++ b/src/cmd/link/internal/loader/loader_test.go @@ -26,9 +26,8 @@ func addDummyObjSym(t *testing.T, ldr *Loader, or *oReader, name string) Sym { } func mkLoader() *Loader { - edummy := func(str string, off int) {} er := ErrorReporter{} - ldr := NewLoader(0, edummy, &er) + ldr := NewLoader(0, &er) er.ldr = ldr return ldr } |