diff options
| author | Bryan C. Mills <bcmills@google.com> | 2020-08-14 17:44:22 -0400 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2020-08-17 19:43:21 +0000 |
| commit | 1b86bdbdc3991c13c6ed156100a5f4918fdd9c6b (patch) | |
| tree | 1630f7d8bec19ca853d9e9804aeb532e44df6f28 /src/cmd/internal/test2json/testdata | |
| parent | f30044a03bc7cf107dbec03c02fb6d0072878252 (diff) | |
| download | go-1b86bdbdc3991c13c6ed156100a5f4918fdd9c6b.tar.xz | |
cmd/test2json: do not emit a final Action if the result is not known
If we are parsing a test output, and the test does not end in the
usual PASS or FAIL line (say, because it panicked), then we need the
exit status of the test binary in order to determine whether the test
passed or failed. If we don't have that status available, we shouldn't
guess arbitrarily — instead, we should omit the final "pass" or "fail"
action entirely.
(In practice, we nearly always DO have the final status, such as when
running 'go test' or 'go tool test2json some.exe'.)
Fixes #40132
Change-Id: Iae482577361a6033395fe4a05d746b980e18c3de
Reviewed-on: https://go-review.googlesource.com/c/go/+/248624
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/internal/test2json/testdata')
| -rw-r--r-- | src/cmd/internal/test2json/testdata/benchshort.json | 1 | ||||
| -rw-r--r-- | src/cmd/internal/test2json/testdata/empty.json | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/src/cmd/internal/test2json/testdata/benchshort.json b/src/cmd/internal/test2json/testdata/benchshort.json index 28e287c848..34b03b9362 100644 --- a/src/cmd/internal/test2json/testdata/benchshort.json +++ b/src/cmd/internal/test2json/testdata/benchshort.json @@ -4,4 +4,3 @@ {"Action":"output","Output":"# but to avoid questions of timing, we just use a file with no \\n at all.\n"} {"Action":"output","Output":"BenchmarkFoo \t"} {"Action":"output","Output":"10000 early EOF"} -{"Action":"pass"} diff --git a/src/cmd/internal/test2json/testdata/empty.json b/src/cmd/internal/test2json/testdata/empty.json index 80b5217501..e69de29bb2 100644 --- a/src/cmd/internal/test2json/testdata/empty.json +++ b/src/cmd/internal/test2json/testdata/empty.json @@ -1 +0,0 @@ -{"Action":"pass"} |