diff options
| author | Keith Randall <khr@golang.org> | 2023-05-02 17:37:00 +0000 |
|---|---|---|
| committer | Keith Randall <khr@google.com> | 2023-05-19 18:10:11 +0000 |
| commit | bd3f44e4ffe54e9cf841ebc8356e403bb38436bd (patch) | |
| tree | fa91f127398bdf3fd9058b37bd7a228f4ad2ae96 /src/cmd/internal/objabi | |
| parent | b60db8f7d92fb2c87b6f416ebb38a6924978aa8c (diff) | |
| download | go-bd3f44e4ffe54e9cf841ebc8356e403bb38436bd.tar.xz | |
cmd/compile: constant-fold loads from constant dictionaries and types
Retrying the original CL with a small modification. The original CL
did not handle the case of reading an itab out of a dictionary
correctly. When we read an itab out of a dictionary, we must treat
the type inside that itab as maybe being put in an interface.
Original CL: 486895
Revert CL: 490156
Change-Id: Id2dc1699d184cd8c63dac83986a70b60b4e6cbd7
Reviewed-on: https://go-review.googlesource.com/c/go/+/491495
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/internal/objabi')
| -rw-r--r-- | src/cmd/internal/objabi/reloctype.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/internal/objabi/reloctype.go b/src/cmd/internal/objabi/reloctype.go index 4dcfe44388..0b231855ec 100644 --- a/src/cmd/internal/objabi/reloctype.go +++ b/src/cmd/internal/objabi/reloctype.go @@ -83,7 +83,8 @@ const ( // direct references. (This is used for types reachable by reflection.) R_USETYPE // R_USEIFACE marks a type is converted to an interface in the function this - // relocation is applied to. The target is a type descriptor. + // relocation is applied to. The target is a type descriptor or an itab + // (in the latter case it refers to the conrete type contained in the itab). // This is a marker relocation (0-sized), for the linker's reachabililty // analysis. R_USEIFACE |