diff options
| author | Kir Kolyshkin <kolyshkin@gmail.com> | 2024-09-04 18:59:49 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-09-06 13:28:35 +0000 |
| commit | 8f2486d2e03e26ea9bc5f680c1a5795256459b7b (patch) | |
| tree | 50823ed9d233b29ae32e47a52ba6611628f1ca17 /src/cmd/internal/obj/ppc64 | |
| parent | a77b93c0b2e2c50d1b0b9d181a4ee4eaf04f8821 (diff) | |
| download | go-8f2486d2e03e26ea9bc5f680c1a5795256459b7b.tar.xz | |
cmd/internal: use t.TempDir in tests
Change-Id: I3d4c66793afa3769a8450e2d65093a0f9115596e
Reviewed-on: https://go-review.googlesource.com/c/go/+/611043
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Diffstat (limited to 'src/cmd/internal/obj/ppc64')
| -rw-r--r-- | src/cmd/internal/obj/ppc64/asm_test.go | 24 |
1 files changed, 6 insertions, 18 deletions
diff --git a/src/cmd/internal/obj/ppc64/asm_test.go b/src/cmd/internal/obj/ppc64/asm_test.go index 0ef457e8d0..ab7af2205e 100644 --- a/src/cmd/internal/obj/ppc64/asm_test.go +++ b/src/cmd/internal/obj/ppc64/asm_test.go @@ -167,11 +167,7 @@ PNOP func TestPfxAlign(t *testing.T) { testenv.MustHaveGoBuild(t) - dir, err := os.MkdirTemp("", "testpfxalign") - if err != nil { - t.Fatalf("could not create directory: %v", err) - } - defer os.RemoveAll(dir) + dir := t.TempDir() pgms := []struct { text []byte @@ -188,7 +184,7 @@ func TestPfxAlign(t *testing.T) { for _, pgm := range pgms { tmpfile := filepath.Join(dir, "x.s") - err = os.WriteFile(tmpfile, pgm.text, 0644) + err := os.WriteFile(tmpfile, pgm.text, 0644) if err != nil { t.Fatalf("can't write output: %v\n", err) } @@ -217,11 +213,7 @@ func TestLarge(t *testing.T) { } testenv.MustHaveGoBuild(t) - dir, err := os.MkdirTemp("", "testlarge") - if err != nil { - t.Fatalf("could not create directory: %v", err) - } - defer os.RemoveAll(dir) + dir := t.TempDir() // A few interesting test cases for long conditional branch fixups tests := []struct { @@ -281,7 +273,7 @@ func TestLarge(t *testing.T) { gen(buf, test.jmpinsn) tmpfile := filepath.Join(dir, "x.s") - err = os.WriteFile(tmpfile, buf.Bytes(), 0644) + err := os.WriteFile(tmpfile, buf.Bytes(), 0644) if err != nil { t.Fatalf("can't write output: %v\n", err) } @@ -336,16 +328,12 @@ func TestPCalign(t *testing.T) { testenv.MustHaveGoBuild(t) - dir, err := os.MkdirTemp("", "testpcalign") - if err != nil { - t.Fatalf("could not create directory: %v", err) - } - defer os.RemoveAll(dir) + dir := t.TempDir() // generate a test with valid uses of PCALIGN tmpfile := filepath.Join(dir, "x.s") - err = os.WriteFile(tmpfile, []byte(validPCAlignSrc), 0644) + err := os.WriteFile(tmpfile, []byte(validPCAlignSrc), 0644) if err != nil { t.Fatalf("can't write output: %v\n", err) } |