diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-11-15 10:14:16 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-11-15 20:21:30 +0000 |
| commit | 5ccee1199e11b830ae32772d5ebc7b35e356b7f3 (patch) | |
| tree | bf800215547a1043057662fe641959f523644502 /src/cmd/internal/obj/objfile_test.go | |
| parent | 6484e813b5ec80a399ed1b8e4608070db2144b39 (diff) | |
| download | go-5ccee1199e11b830ae32772d5ebc7b35e356b7f3.tar.xz | |
cmd/internal/obj: use testenv.Command instead of exec.Command in tests
testenv.Command sets a default timeout based on the test's deadline
and sends SIGQUIT (where supported) in case of a hang.
Change-Id: Ica1a9985f9abb1935434367c9c8ba28fc50f331d
Reviewed-on: https://go-review.googlesource.com/c/go/+/450699
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/cmd/internal/obj/objfile_test.go')
| -rw-r--r-- | src/cmd/internal/obj/objfile_test.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/cmd/internal/obj/objfile_test.go b/src/cmd/internal/obj/objfile_test.go index 79204c1858..9e99056803 100644 --- a/src/cmd/internal/obj/objfile_test.go +++ b/src/cmd/internal/obj/objfile_test.go @@ -8,7 +8,6 @@ import ( "bytes" "internal/testenv" "os" - "os/exec" "path/filepath" "testing" "unsafe" @@ -111,7 +110,7 @@ func TestSymbolTooLarge(t *testing.T) { // Issue 42054 t.Fatalf("failed to write source file: %v\n", err) } obj := filepath.Join(tmpdir, "p.o") - cmd := exec.Command(testenv.GoToolPath(t), "tool", "compile", "-p=p", "-o", obj, src) + cmd := testenv.Command(t, testenv.GoToolPath(t), "tool", "compile", "-p=p", "-o", obj, src) out, err := cmd.CombinedOutput() if err == nil { t.Fatalf("did not fail\noutput: %s", out) @@ -137,7 +136,7 @@ func TestNoRefName(t *testing.T) { // Build the fmt package with norefname. Not rebuilding all packages to save time. // Also testing that norefname and non-norefname packages can link together. - cmd := exec.Command(testenv.GoToolPath(t), "build", "-gcflags=fmt=-d=norefname", "-o", exe, src) + cmd := testenv.Command(t, testenv.GoToolPath(t), "build", "-gcflags=fmt=-d=norefname", "-o", exe, src) out, err := cmd.CombinedOutput() if err != nil { t.Fatalf("build failed: %v, output:\n%s", err, out) |