diff options
| author | diaxu01 <dianhong.xu@arm.com> | 2019-08-21 09:31:35 +0000 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2019-10-08 16:20:53 +0000 |
| commit | 9ce5cad0aaf5eceda6927acec2db96ba5fd7ef07 (patch) | |
| tree | e1e31e9e237ea1e156e9b93390f5bd73d2764f11 /src/cmd/internal/obj/arm64/a.out.go | |
| parent | d458b868360c0e223979951dd4b6ce3ce92cfd68 (diff) | |
| download | go-9ce5cad0aaf5eceda6927acec2db96ba5fd7ef07.tar.xz | |
cmd/internal/obj/arm64: add error checking for system registers.
This CL adds system register error checking test cases. There're two kinds of
error test cases:
1. illegal combination.
MRS should be used in this way: MRS <system register>, <general register>.
MSR should be used in this way: MSR <general register>, <system register>.
Error usage examples:
MRS R8, VTCR_EL2 // ERROR "illegal combination"
MSR VTCR_EL2, R8 // ERROR "illegal combination"
2. illegal read or write access.
Error usage examples:
MSR R7, MIDR_EL1 // ERROR "expected writable system register or pstate"
MRS OSLAR_EL1, R3 // ERROR "expected readable system register"
This CL reads system registers readable and writeable property to check whether
they're used with legal read or write access. This property is named AccessFlags
in sysRegEnc.go, and it is automatically generated by modifing the system register
generator.
Change-Id: Ic83d5f372de38d1ecd0df1ca56b354ee157f16b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/194917
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/cmd/internal/obj/arm64/a.out.go')
| -rw-r--r-- | src/cmd/internal/obj/arm64/a.out.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/internal/obj/arm64/a.out.go b/src/cmd/internal/obj/arm64/a.out.go index 4e5eb75a22..bd9e9542b8 100644 --- a/src/cmd/internal/obj/arm64/a.out.go +++ b/src/cmd/internal/obj/arm64/a.out.go @@ -195,11 +195,11 @@ const ( // Special registers, after subtracting obj.RBaseARM64, bit 12 indicates // a special register and the low bits select the register. -// AUTO_SYSREG_END is the last item in the automatically generated system register +// SYSREG_END is the last item in the automatically generated system register // declaration, and it is defined in the sysRegEnc.go file. const ( REG_SPECIAL = obj.RBaseARM64 + 1<<12 - REG_DAIFSet = AUTO_SYSREG_END + iota + REG_DAIFSet = SYSREG_END + iota REG_DAIFClr REG_PLDL1KEEP REG_PLDL1STRM |