diff options
| author | Ian Lance Taylor <iant@golang.org> | 2021-12-18 15:54:38 -0800 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2021-12-20 23:32:14 +0000 |
| commit | 6713b5dbbc4b3bbfa2022538501c7f8104f1e5fd (patch) | |
| tree | 8687310c23dc1b55d8b72960ef0999c6d35ac4cf /src/cmd/doc/doc_test.go | |
| parent | 9901d9e87a47b775edd0e75edb19ba696091603e (diff) | |
| download | go-6713b5dbbc4b3bbfa2022538501c7f8104f1e5fd.tar.xz | |
cmd/doc: don't log on constraint type elements
Fixes #50256
Change-Id: I2327a0b28f8173c801ed2946bec8083967667027
Reviewed-on: https://go-review.googlesource.com/c/go/+/373314
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Diffstat (limited to 'src/cmd/doc/doc_test.go')
| -rw-r--r-- | src/cmd/doc/doc_test.go | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go index af7793133e..0ff9edcde3 100644 --- a/src/cmd/doc/doc_test.go +++ b/src/cmd/doc/doc_test.go @@ -7,6 +7,7 @@ package main import ( "bytes" "flag" + "log" "os" "path/filepath" "regexp" @@ -125,6 +126,9 @@ var tests = []test{ `func MultiLineFunc\(x interface{ ... }\) \(r struct{ ... }\)`, // Multi line function. `var LongLine = newLongLine\(("someArgument[1-4]", ){4}...\)`, // Long list of arguments. `type T1 = T2`, // Type alias + `type SimpleConstraint interface{ ... }`, + `type TildeConstraint interface{ ... }`, + `type StructConstraint interface{ ... }`, }, []string{ `const internalConstant = 2`, // No internal constants. @@ -199,6 +203,9 @@ var tests = []test{ `Comment about exported method`, `type T1 = T2`, `type T2 int`, + `type SimpleConstraint interface {`, + `type TildeConstraint interface {`, + `type StructConstraint interface {`, }, []string{ `constThree`, @@ -822,13 +829,19 @@ var tests = []test{ func TestDoc(t *testing.T) { maybeSkip(t) + defer log.SetOutput(log.Writer()) for _, test := range tests { var b bytes.Buffer var flagSet flag.FlagSet + var logbuf bytes.Buffer + log.SetOutput(&logbuf) err := do(&b, &flagSet, test.args) if err != nil { t.Fatalf("%s %v: %s\n", test.name, test.args, err) } + if logbuf.Len() > 0 { + t.Errorf("%s %v: unexpected log messages:\n%s", test.name, test.args, logbuf.Bytes()) + } output := b.Bytes() failed := false for j, yes := range test.yes { |