diff options
| author | Lynn Boger <laboger@linux.vnet.ibm.com> | 2021-04-30 10:21:18 -0500 |
|---|---|---|
| committer | Lynn Boger <laboger@linux.vnet.ibm.com> | 2021-05-03 12:20:09 +0000 |
| commit | 30674ae91b7fa20b9f68e1e79d8d7cd8ead495cd (patch) | |
| tree | b858c24132e94b17b4ded9f3a0d525220076bf22 /src/cmd/dist | |
| parent | 2c9f5a1da823773c436f8b2c119635797d6db2d3 (diff) | |
| download | go-30674ae91b7fa20b9f68e1e79d8d7cd8ead495cd.tar.xz | |
cmd/dist: disable misc/cgo/testsanitizers on ppc64le
A while back in this release the sanitizer tests were enabled
for ppc64le, where previously they were never run. This
uncovered some errors in these tests on ppc64le. One linker
fix was made but there are still bugs in how tsan is made to
work within the code, especially in how signals are enabled
with cgo.
Some attempts were made to make this work but intermittent
failures continue to happen with the Trybots so I am just
going to disable this test for ppc64le within cmd/dist.
Updates #45040
Change-Id: I5392368ccecd4079ef568d0c645c9f7c94016d99
Reviewed-on: https://go-review.googlesource.com/c/go/+/315430
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd/dist')
| -rw-r--r-- | src/cmd/dist/test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 8b1ec458ed..33fabd3554 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -749,8 +749,9 @@ func (t *tester) registerTests() { if gohostos == "linux" && goarch == "amd64" { t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", ".") } - if goos == "linux" { + if goos == "linux" && goarch != "ppc64le" { // because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux. + // Some inconsistent failures happen on ppc64le so disable for now. t.registerHostTest("testsanitizers", "../misc/cgo/testsanitizers", "misc/cgo/testsanitizers", ".") } if t.hasBash() && goos != "android" && !t.iOS() && gohostos != "windows" { |