diff options
| author | Dan Scales <danscales@google.com> | 2021-11-02 12:30:37 -0700 |
|---|---|---|
| committer | Dan Scales <danscales@google.com> | 2021-11-02 23:05:17 +0000 |
| commit | eb63cbd2950e703ff2a6bd04330e97dc76c7923d (patch) | |
| tree | 16cfd39fbc29e17bb6b8a9f499ea1dd0b1f753c3 /src/cmd/compile | |
| parent | 2157498dfee125e43cc37cad622fb7d2115dd3a8 (diff) | |
| download | go-eb63cbd2950e703ff2a6bd04330e97dc76c7923d.tar.xz | |
cmd/compile: remove TODO that is no longer relevant
types2 methods are now sorted in the same way as types1, so this TODO is
no longer needed. (Comment change only).
Change-Id: Ic975ce001a5d54f15381a9cb7b6969dff795e3b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/360856
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile')
| -rw-r--r-- | src/cmd/compile/internal/noder/expr.go | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/cmd/compile/internal/noder/expr.go b/src/cmd/compile/internal/noder/expr.go index d19513a1ac..24e6dbefe7 100644 --- a/src/cmd/compile/internal/noder/expr.go +++ b/src/cmd/compile/internal/noder/expr.go @@ -235,12 +235,6 @@ func (g *irgen) selectorExpr(pos src.XPos, typ types2.Type, expr *syntax.Selecto return DotField(pos, x, last) } - // TODO(danscales,mdempsky): Interface method sets are not sorted the - // same between types and types2. In particular, using "last" here - // without conversion will likely fail if an interface contains - // unexported methods from two different packages (due to cross-package - // interface embedding). - var n ir.Node method2 := selinfo.Obj().(*types2.Func) |