diff options
| author | Mark Freeman <mark@golang.org> | 2026-01-30 14:23:02 -0500 |
|---|---|---|
| committer | Robert Griesemer <gri@google.com> | 2026-02-02 15:18:11 -0800 |
| commit | 7fd116f86451d7262f7683629b90c8adc0137f53 (patch) | |
| tree | e16f90c4bbfda0b4cf2d09c6d9fe5a04904f7a08 /src/cmd/compile | |
| parent | 8ac41b52c4b7a6ab9c41d008abbe254270200b8e (diff) | |
| download | go-7fd116f86451d7262f7683629b90c8adc0137f53.tar.xz | |
go/types, types2: add missing Named.unpack call in Checker.hasVarSize
CL 734980 swapped use of Type.Underlying() in Checker.hasVarSize for
traversal of Named.fromRHS. It forgot to call Named.unpack() before
inspecting Named.fromRHS, allowing access of unexpanded instantiated
types.
These unexpanded instantiated types are then mistakenly marked as having
fixed size, which fails assertions downstream. This change adds the
missing Named.unpack() call and swaps direct access of Named.fromRHS for
Named.rhs(), which verifies such access in debug mode.
Fixes #77382
Change-Id: I324bbbbf790f8b09e95902ebe67f775483f88417
Reviewed-on: https://go-review.googlesource.com/c/go/+/740620
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/cmd/compile')
| -rw-r--r-- | src/cmd/compile/internal/types2/builtins.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/types2/builtins.go b/src/cmd/compile/internal/types2/builtins.go index 5965228585..5fa0e6c6f0 100644 --- a/src/cmd/compile/internal/types2/builtins.go +++ b/src/cmd/compile/internal/types2/builtins.go @@ -1009,7 +1009,8 @@ func sliceElem(x *operand) (Type, *typeError) { // yet been checked. func (check *Checker) hasVarSize(t Type) bool { // Note: We could use Underlying here, but passing through the RHS may yield - // better error messages. + // better error messages and allows us to stash the result on each traversed + // Named type. switch t := Unalias(t).(type) { case *Named: if t.stateHas(hasVarSize) { @@ -1025,7 +1026,9 @@ func (check *Checker) hasVarSize(t Type) bool { check.push(t.obj) defer check.pop() - varSize := check.hasVarSize(t.fromRHS) + // Careful, we're inspecting t.fromRHS, so we need to unpack first. + t.unpack() + varSize := check.hasVarSize(t.rhs()) t.mu.Lock() defer t.mu.Unlock() |