diff options
| author | cuishuang <imcusg@gmail.com> | 2025-12-08 12:18:59 +0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-12-09 10:42:20 -0800 |
| commit | 36bca3166e18db52687a4d91ead3f98ffe6d00b8 (patch) | |
| tree | 1c6b71ec0fb25998e9f9aa042fd6b7d13cbd6d17 /src/cmd/compile | |
| parent | b9693a2d9a89168b86cf01033b8420bf8db652d6 (diff) | |
| download | go-36bca3166e18db52687a4d91ead3f98ffe6d00b8.tar.xz | |
cmd: fix some issues in the comments
Change-Id: Id2c4152b43c7ee1a687e49da7dda5a690e554231
Reviewed-on: https://go-review.googlesource.com/c/go/+/727900
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile')
| -rw-r--r-- | src/cmd/compile/internal/inline/inlheur/analyze_func_params.go | 6 | ||||
| -rw-r--r-- | src/cmd/compile/internal/test/testdata/arith_test.go | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/cmd/compile/internal/inline/inlheur/analyze_func_params.go b/src/cmd/compile/internal/inline/inlheur/analyze_func_params.go index f6bd84c3f5..abfcb3ab32 100644 --- a/src/cmd/compile/internal/inline/inlheur/analyze_func_params.go +++ b/src/cmd/compile/internal/inline/inlheur/analyze_func_params.go @@ -122,9 +122,9 @@ func (pa *paramsAnalyzer) findParamIdx(n *ir.Name) int { type testfType func(x ir.Node, param *ir.Name, idx int) (bool, bool) -// paramsAnalyzer invokes function 'testf' on the specified expression -// 'x' for each parameter, and if the result is TRUE, or's 'flag' into -// the flags for that param. +// checkParams invokes function 'testf' on the specified expression 'x' +// for each parameter. If the result is TRUE, it OR's either 'flag' or 'mayflag' +// into the flags for that param, depending on whether we are in a conditional context. func (pa *paramsAnalyzer) checkParams(x ir.Node, flag ParamPropBits, mayflag ParamPropBits, testf testfType) { for idx, p := range pa.params { if !pa.top[idx] && pa.values[idx] == ParamNoInfo { diff --git a/src/cmd/compile/internal/test/testdata/arith_test.go b/src/cmd/compile/internal/test/testdata/arith_test.go index 34ac73c068..6f53618b59 100644 --- a/src/cmd/compile/internal/test/testdata/arith_test.go +++ b/src/cmd/compile/internal/test/testdata/arith_test.go @@ -223,7 +223,7 @@ func testArithConstShift(t *testing.T) { } } -// overflowConstShift_ssa verifies that constant folding for shift +// overflowConstShift64_ssa verifies that constant folding for shift // doesn't wrap (i.e. x << MAX_INT << 1 doesn't get folded to x << 0). // //go:noinline @@ -1408,7 +1408,7 @@ var ( // These have to be global to avoid getting constant-folded in the function body: // as locals, prove can see that they are actually constants. sixU, nineteenU uint64 = 6, 19 - sixS, nineteenS int64 = 6, 19 + sixS, nineteenS int64 = 6, 19 ) // testDivisibility confirms that rewrite rules x%c ==0 for c constant are correct. |