all: use strings.ReplaceAll where applicable

```
find . \
-not -path './.git/*' \
-not -path './test/*' \
-not -path './src/cmd/vendor/*' \
-not -wholename './src/strings/example_test.go' \
-type f \
-exec \
sed -i -E 's/strings\.Replace\((.+), -1\)/strings\.ReplaceAll\(\1\)/g' {} \;
```

Change-Id: I59e2e91b3654c41a32f17dd91ec56f250198f0d6
GitHub-Last-Rev: 0868b1eccc945ca62a5ed0e56a4054994d4bd659
GitHub-Pull-Request: golang/go#73370
Reviewed-on: https://go-review.googlesource.com/c/go/+/665395
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>

2 files changed, 5 insertions, 5 deletions

diff --git a/src/cmd/compile/internal/test/testdata/flowgraph_generator1.go b/src/cmd/compile/internal/test/testdata/flowgraph_generator1.go
index ad22601f43..66ad0869dd 100644
--- a/src/cmd/compile/internal/test/testdata/flowgraph_generator1.go
+++ b/src/cmd/compile/internal/test/testdata/flowgraph_generator1.go
@@ -99,7 +99,7 @@ var labels string = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
 func blocks(spec string) (blocks []string, fnameBase string) {
 	spec = strings.ToUpper(spec)
 	blocks = strings.Split(spec, ",")
-	fnameBase = strings.Replace(spec, ",", "_", -1)
+	fnameBase = strings.ReplaceAll(spec, ",", "_")
 	return
 }
 
diff --git a/src/cmd/compile/internal/test/testdata/gen/arithConstGen.go b/src/cmd/compile/internal/test/testdata/gen/arithConstGen.go
index 1649f46557..ecf6bab15a 100644
--- a/src/cmd/compile/internal/test/testdata/gen/arithConstGen.go
+++ b/src/cmd/compile/internal/test/testdata/gen/arithConstGen.go
@@ -175,7 +175,7 @@ func {{.Name}}_{{.FNumber}}_{{.Type_}}(a {{.Type_}}) {{.Type_}} { return {{.Numb
 			if len(s.u) > 0 {
 				for _, i := range s.u {
 					fd.Number = fmt.Sprintf("%d", i)
-					fd.FNumber = strings.Replace(fd.Number, "-", "Neg", -1)
+					fd.FNumber = strings.ReplaceAll(fd.Number, "-", "Neg")
 
 					// avoid division by zero
 					if o.name != "mod" && o.name != "div" || i != 0 {
@@ -201,7 +201,7 @@ func {{.Name}}_{{.FNumber}}_{{.Type_}}(a {{.Type_}}) {{.Type_}} { return {{.Numb
 				}
 				for _, i := range s.i {
 					fd.Number = fmt.Sprintf("%d", i)
-					fd.FNumber = strings.Replace(fd.Number, "-", "Neg", -1)
+					fd.FNumber = strings.ReplaceAll(fd.Number, "-", "Neg")
 
 					// avoid division by zero
 					if o.name != "mod" && o.name != "div" || i != 0 {
@@ -242,7 +242,7 @@ type test_%[1]s%[2]s struct {
 				fd := cfncData{s.name, o.name, s.name, o.symbol, "", "", "", ""}
 				for _, i := range s.u {
 					fd.Number = fmt.Sprintf("%d", i)
-					fd.FNumber = strings.Replace(fd.Number, "-", "Neg", -1)
+					fd.FNumber = strings.ReplaceAll(fd.Number, "-", "Neg")
 
 					// unsigned
 					for _, j := range s.u {
@@ -282,7 +282,7 @@ type test_%[1]s%[2]s struct {
 				fd := cfncData{s.name, o.name, s.name, o.symbol, "", "", "", ""}
 				for _, i := range s.i {
 					fd.Number = fmt.Sprintf("%d", i)
-					fd.FNumber = strings.Replace(fd.Number, "-", "Neg", -1)
+					fd.FNumber = strings.ReplaceAll(fd.Number, "-", "Neg")
 					for _, j := range s.i {
 						if o.name != "mod" && o.name != "div" || j != 0 {
 							fd.Ans = ansS(i, j, s.name, o.symbol)