diff options
| author | Keith Randall <khr@golang.org> | 2025-08-12 15:14:13 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-08-12 16:04:18 -0700 |
| commit | 4e182db5fc876564a4f87a0602c58ea0ddc6e37c (patch) | |
| tree | dcb3f85255f7391b82a5dc697cfd8aef851d0075 /src/cmd/compile/internal/ssa/regalloc.go | |
| parent | d2b3c1a5045437233ca6a8adc7e36293cd73655a (diff) | |
| download | go-4e182db5fc876564a4f87a0602c58ea0ddc6e37c.tar.xz | |
Revert "cmd/compile: use generated loops instead of DUFFCOPY on amd64"
This reverts commit ec9e1176c3209cf92e73e3deb2d8073fab5ea4d6 (CL 678620).
Reason for revert: causing regalloc to get into an infinite loop
Change-Id: Ie53c58c6126804af6d6883ea4acdcfb632a172bd
Reviewed-on: https://go-review.googlesource.com/c/go/+/695196
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/regalloc.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/regalloc.go | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/src/cmd/compile/internal/ssa/regalloc.go b/src/cmd/compile/internal/ssa/regalloc.go index 42dae0088d..c0881c7a45 100644 --- a/src/cmd/compile/internal/ssa/regalloc.go +++ b/src/cmd/compile/internal/ssa/regalloc.go @@ -561,14 +561,7 @@ func (s *regAllocState) allocValToReg(v *Value, mask regMask, nospill bool, pos pos = pos.WithNotStmt() // Check if v is already in a requested register. if mask&vi.regs != 0 { - mask &= vi.regs - r := pickReg(mask) - if mask.contains(s.SPReg) { - // Prefer the stack pointer if it is allowed. - // (Needed because the op might have an Aux symbol - // that needs SP as its base.) - r = s.SPReg - } + r := pickReg(mask & vi.regs) if !s.allocatable.contains(r) { return v // v is in a fixed register } |
