diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-05-10 16:06:16 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2022-05-13 21:28:41 +0000 |
| commit | e99275241c4e4bde6ff2a8598e558a2bea151ef7 (patch) | |
| tree | e2aa1f06cbc8dc5d4fcfb4af44dc36e3fd6d7907 /src/cmd/compile/internal/noder | |
| parent | 80f3e3deba619fcf0ddcb547c61c9cbbd8b81968 (diff) | |
| download | go-e99275241c4e4bde6ff2a8598e558a2bea151ef7.tar.xz | |
cmd/compile/internal/types: change NewTypeParam to match New{Basic,Named}
NewBasic and NewNamed take an Object (i.e., *ir.Name), so that callers
don't need to call SetNod. This CL changes NewTypeParam to follow the
same convention. Following up on recent Ntype removal, this allows
getting rid of Type.SetNod entirely.
While here, Type.SetSym is unused too.
Change-Id: Ibe0f5747e2ab4a9512b65142b6d3006704b60bd3
Reviewed-on: https://go-review.googlesource.com/c/go/+/405654
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/noder')
| -rw-r--r-- | src/cmd/compile/internal/noder/types.go | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/cmd/compile/internal/noder/types.go b/src/cmd/compile/internal/noder/types.go index ff3a4d982d..57b35e602b 100644 --- a/src/cmd/compile/internal/noder/types.go +++ b/src/cmd/compile/internal/noder/types.go @@ -253,11 +253,10 @@ func (g *irgen) typ0(typ types2.Type) *types.Type { // this types2-to-types1 translation. return sym.Def.Type() } - tp := types.NewTypeParam(sym, typ.Index()) - nname := ir.NewDeclNameAt(g.pos(typ.Obj().Pos()), ir.OTYPE, sym) - sym.Def = nname - nname.SetType(tp) - tp.SetNod(nname) + obj := ir.NewDeclNameAt(g.pos(typ.Obj().Pos()), ir.OTYPE, sym) + sym.Def = obj + tp := types.NewTypeParam(obj, typ.Index()) + obj.SetType(tp) // Set g.typs[typ] in case the bound methods reference typ. g.typs[typ] = tp |