diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-05-17 15:26:18 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-05-17 22:44:52 +0000 |
| commit | 6382c39e15ce68996a3848ad6f0ca15570e35ff5 (patch) | |
| tree | d94dedb7dca669e0bb05ed3c18de2d227dc2f9ae /src/cmd/compile/internal/noder | |
| parent | d63865b5d19ec3ca57aa30b45b2e0b57b3d54087 (diff) | |
| download | go-6382c39e15ce68996a3848ad6f0ca15570e35ff5.tar.xz | |
cmd/compile/internal/noder: remove TODO about position handling
types2 uses nopos as the position for predeclared objects, so it's
expected that we'll see !pos.IsKnown() when translating types2
representations into IR.
Change-Id: I8708c2e9815e3dd27da8066c67c73f5586ac4617
Reviewed-on: https://go-review.googlesource.com/c/go/+/406896
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/noder')
| -rw-r--r-- | src/cmd/compile/internal/noder/posmap.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/noder/posmap.go b/src/cmd/compile/internal/noder/posmap.go index f22628f845..6c7e57c996 100644 --- a/src/cmd/compile/internal/noder/posmap.go +++ b/src/cmd/compile/internal/noder/posmap.go @@ -26,8 +26,9 @@ func (m *posMap) pos(p poser) src.XPos { return m.makeXPos(p.Pos()) } func (m *posMap) end(p ender) src.XPos { return m.makeXPos(p.End()) } func (m *posMap) makeXPos(pos syntax.Pos) src.XPos { + // Predeclared objects (e.g., the result parameter for error.Error) + // do not have a position. if !pos.IsKnown() { - // TODO(mdempsky): Investigate restoring base.Fatalf. return src.NoXPos } |