diff options
| author | Mateusz Poliwczak <mpoliwczak34@gmail.com> | 2022-12-03 13:50:45 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-01-27 00:42:08 +0000 |
| commit | 3dc85a32fc2c7216f18374bccd37eaed7ed2db7f (patch) | |
| tree | 1bc8683e4dad1b74123cc121a0e331e2d30c49c4 /src/cmd/compile/internal/noder | |
| parent | d0851777daaec578ff94e9cbae0cedbff4ac625b (diff) | |
| download | go-3dc85a32fc2c7216f18374bccd37eaed7ed2db7f.tar.xz | |
net: report completed when context is done in cgoLookupIP and cgoLookupPTR
All the Lookup* methods that resolve hostnames eventually call lookupIP
or lookupHost method. When the order is selected to be hostLookupCGO
then lookupHost calls cgoLookupHost which internally calls cgoLookupIP
(the lookupIP directly calls cgoLookupIP).
When we provide a context that is cancelled after cgo call, then the
cgoLookupIP returns completed == false, which caues the
lookupIP/lookupHost to fallback to the go resolver.
This fallback is unnecessary because our context is already cancelled.
The same thing can happen to LookupAddr.
Change-Id: Ifff7716c461f05d954ef43b5205865103558b410
GitHub-Last-Rev: 2ef2023e8c51cdd251986f79e94aba86a0722230
GitHub-Pull-Request: golang/go#57042
Reviewed-on: https://go-review.googlesource.com/c/go/+/454696
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/cmd/compile/internal/noder')
0 files changed, 0 insertions, 0 deletions