diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-03-15 22:44:31 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2022-03-17 00:12:40 +0000 |
| commit | 1cfe1007cdf17ee381443cd0d8ae31962805f96e (patch) | |
| tree | 8e5f85262729baa85566ef0d37bf19fee93b6958 /src/cmd/compile/internal/noder | |
| parent | 8d4da2c7b582783f30f9c93c2bcb0641748103e2 (diff) | |
| download | go-1cfe1007cdf17ee381443cd0d8ae31962805f96e.tar.xz | |
cmd/compile: remove typecheckdef and Name.Walkdef
The only remaining use for typecheckdef after CL 393256 is to
typecheck the ONAME node that represents function names, so we might
as well just move that code into tcFunc instead.
Updates #51691.
Change-Id: Icbca51d4b0fb33c90faa95f16254c7171b171d8a
Reviewed-on: https://go-review.googlesource.com/c/go/+/393367
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'src/cmd/compile/internal/noder')
| -rw-r--r-- | src/cmd/compile/internal/noder/expr.go | 1 | ||||
| -rw-r--r-- | src/cmd/compile/internal/noder/object.go | 1 | ||||
| -rw-r--r-- | src/cmd/compile/internal/noder/reader.go | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/src/cmd/compile/internal/noder/expr.go b/src/cmd/compile/internal/noder/expr.go index 4b5ae706c1..566abda963 100644 --- a/src/cmd/compile/internal/noder/expr.go +++ b/src/cmd/compile/internal/noder/expr.go @@ -439,7 +439,6 @@ func (g *irgen) funcLit(typ2 types2.Type, expr *syntax.FuncLit) ir.Node { for _, cv := range fn.ClosureVars { cv.SetType(cv.Canonical().Type()) cv.SetTypecheck(1) - cv.SetWalkdef(1) } if g.topFuncIsGeneric { diff --git a/src/cmd/compile/internal/noder/object.go b/src/cmd/compile/internal/noder/object.go index 37a995b519..e8dbaac161 100644 --- a/src/cmd/compile/internal/noder/object.go +++ b/src/cmd/compile/internal/noder/object.go @@ -171,7 +171,6 @@ func (g *irgen) objFinish(name *ir.Name, class ir.Class, typ *types.Type) { } name.SetTypecheck(1) - name.SetWalkdef(1) if ir.IsBlank(name) { return diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index dd3bb1523e..62875ba073 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -155,7 +155,6 @@ func setType(n ir.Node, typ *types.Type) { n.SetTypecheck(1) if name, ok := n.(*ir.Name); ok { - name.SetWalkdef(1) name.Ntype = ir.TypeNode(name.Type()) } } |