diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-08-31 13:48:06 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-08-31 22:22:43 +0000 |
| commit | e4b624eae5fa3c51b8ca808da29442d3e3aaef04 (patch) | |
| tree | 03c9b4a666c1adbdba80ce5ce2a894a46ada94e7 /src/cmd/compile/internal/noder/unified.go | |
| parent | 33a7e5a4b49fa04ce6f65b5b0645a44a0c93eaad (diff) | |
| download | go-e4b624eae5fa3c51b8ca808da29442d3e3aaef04.tar.xz | |
cmd/compile: use HaveInlineBody for unified IR
In go.dev/cl/419674 I added a mechanism to the inliner to allow
inlining to fail gracefully when a function body is missing, but I
missed we already have a mechanism for that: typecheck.HaveInlineBody.
This CL makes it overridable so that unified IR can plug in its
appropriate logic, like it does with the logic for building the
ir.InlinedCallExpr node.
While here, rename inline.NewInline to inline.InlineCall, because the
name "NewInline" is now a misnomer since we initialize it to oldInline
(now named oldInlineCall).
Change-Id: I4e65618d3725919f69e6f43cf409699d20fb797c
Reviewed-on: https://go-review.googlesource.com/c/go/+/427234
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/noder/unified.go')
| -rw-r--r-- | src/cmd/compile/internal/noder/unified.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/noder/unified.go b/src/cmd/compile/internal/noder/unified.go index 394336c020..b8e4fe78d7 100644 --- a/src/cmd/compile/internal/noder/unified.go +++ b/src/cmd/compile/internal/noder/unified.go @@ -69,7 +69,8 @@ var localPkgReader *pkgReader // In other words, we have all the necessary information to build the generic IR form // (see writer.captureVars for an example). func unified(noders []*noder) { - inline.NewInline = InlineCall + inline.InlineCall = unifiedInlineCall + typecheck.HaveInlineBody = unifiedHaveInlineBody data := writePkgStub(noders) |