diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-10-17 16:57:07 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-11-08 21:26:09 +0000 |
| commit | 9944ba757b0f8005cfb7715d41592c7e13c0a2b8 (patch) | |
| tree | 42e0158764779d2e9a521beb4161e9ce84264944 /src/cmd/compile/internal/noder/reader.go | |
| parent | a7538d78214920b798a1914a2a789ae833d6f1e1 (diff) | |
| download | go-9944ba757b0f8005cfb7715d41592c7e13c0a2b8.tar.xz | |
cmd/compile: fix transitive inlining of generic functions
If an imported, non-generic function F transitively calls a generic
function G[T], we may need to call CanInline on G[T].
While here, we can also take advantage of the fact that we know G[T]
was already seen and compiled in an imported package, so we don't need
to call InlineCalls or add it to typecheck.Target.Decls. This saves us
from wasting compile time re-creating DUPOK symbols that we know
already exist in the imported package's link objects.
Fixes #56280.
Change-Id: I3336786bee01616ee9f2b18908738e4ca41c8102
Reviewed-on: https://go-review.googlesource.com/c/go/+/443535
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/noder/reader.go')
| -rw-r--r-- | src/cmd/compile/internal/noder/reader.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index fe90f52b4d..d03da27a46 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -3485,7 +3485,7 @@ func unifiedInlineCall(call *ir.CallExpr, fn *ir.Func, inlIndex int) *ir.Inlined // potentially be recursively inlined themselves; but we shouldn't // need to read in the non-inlined bodies for the declarations // themselves. But currently it's an easy fix to #50552. - readBodies(typecheck.Target) + readBodies(typecheck.Target, true) deadcode.Func(r.curfn) |