diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-07-18 12:15:09 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2022-07-19 23:02:28 +0000 |
| commit | 76a82f09d6da7e6fe18b703e5497795a19a780df (patch) | |
| tree | 49f05ccca13fdcd9366b16d3d60da9757b6a7c89 /src/cmd/compile/internal/noder/reader.go | |
| parent | 055a5e55faf0f5c8d5bb6db2e17d5d48f13a584c (diff) | |
| download | go-76a82f09d6da7e6fe18b703e5497795a19a780df.tar.xz | |
[dev.unified] cmd/compile/internal/noder: prefer *At functions
Unified IR tries to avoid depending on base.Pos, so we should prefer
explicit position arguments wherever possible.
Change-Id: I7163b1b8c5244fe7c2a7989e6a3f459a21a23e81
Reviewed-on: https://go-review.googlesource.com/c/go/+/418096
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/noder/reader.go')
| -rw-r--r-- | src/cmd/compile/internal/noder/reader.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index 00aafff2d9..d93859f6ef 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -1525,7 +1525,7 @@ func (r *reader) switchStmt(label *types.Sym) ir.Node { for len(rtypes) < i { rtypes = append(rtypes, nil) } - rtypes = append(rtypes, reflectdata.TypePtr(typ)) + rtypes = append(rtypes, reflectdata.TypePtrAt(cas.Pos(), typ)) } } } @@ -1976,7 +1976,7 @@ func (r *reader) exprType(nilOK bool) ir.Node { setBasePos(pos) lsymPtr := func(lsym *obj.LSym) ir.Node { - return typecheck.Expr(typecheck.NodAddr(ir.NewLinksymExpr(pos, lsym, types.Types[types.TUINT8]))) + return typecheck.Expr(typecheck.NodAddrAt(pos, ir.NewLinksymExpr(pos, lsym, types.Types[types.TUINT8]))) } var typ *types.Type |
