diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2023-08-20 15:07:00 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-08-22 20:57:01 +0000 |
| commit | 3d15bfaa3e05c321dbec48bbcc634a3759b0b18a (patch) | |
| tree | 2278db73ff5b1499974c46acd0ac97db7e2760bf /src/cmd/compile/internal/noder/reader.go | |
| parent | 4b9a70a3b7101d01c67f1c7f839ab4f1234fda2e (diff) | |
| download | go-3d15bfaa3e05c321dbec48bbcc634a3759b0b18a.tar.xz | |
cmd/compile/internal/types: simplify iterating all parameters
The types.RecvsParamsResults, etc. helpers existed to make it "easier"
to iterate over all parameters, or recvs+params, or params+results;
but they end up still being quite clumsy to use due to the design goal
of not allocating temporary slices.
Now that recvs+params+results are stored in a single consecutive slice
anyway, we can just return different subslices and simplify the loops.
Change-Id: I84791b80dc099dfbfbbe6eddbc006135528c23b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/521375
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/cmd/compile/internal/noder/reader.go')
| -rw-r--r-- | src/cmd/compile/internal/noder/reader.go | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index 6ab7b272a6..2a526dbe69 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -1109,10 +1109,8 @@ func (r *reader) funcExt(name *ir.Name, method *types.Sym) { fn.ABI = obj.ABI(r.Uint64()) // Escape analysis. - for _, fs := range &types.RecvsParams { - for _, f := range fs(name.Type()) { - f.Note = r.String() - } + for _, f := range name.Type().RecvParams() { + f.Note = r.String() } if r.Bool() { |