diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2017-08-24 15:36:47 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2017-08-25 08:18:58 +0000 |
| commit | 180bfc4bd49343cb280d1e162a4d326db7b35a6f (patch) | |
| tree | c019f17228fd4cbe9eebff90c676f008ec33cc7a /src/cmd/compile/internal/gc/noder.go | |
| parent | a9f832a6aedbce206d44d099c67448e8aa747690 (diff) | |
| download | go-180bfc4bd49343cb280d1e162a4d326db7b35a6f.tar.xz | |
cmd/compile: simplify noding for struct embedding
Since golang.org/cl/31670, we've stopped using the 'embedded' function
for handling struct embeddings within package export data. Now the
only remaining use is for Go source files, which allows for some
substantial simplifications:
1. CenterDot never appears within Go source files, so that logic can
simply be removed.
2. The field name will always be declared in the local package.
Passes toolstash-check.
Change-Id: I59505f62824206dd5de0782918f98fbef6e93224
Reviewed-on: https://go-review.googlesource.com/58790
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/gc/noder.go')
| -rw-r--r-- | src/cmd/compile/internal/gc/noder.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/gc/noder.go b/src/cmd/compile/internal/gc/noder.go index 5872640eca..f4089599fe 100644 --- a/src/cmd/compile/internal/gc/noder.go +++ b/src/cmd/compile/internal/gc/noder.go @@ -689,7 +689,11 @@ func (p *noder) embedded(typ syntax.Expr) *Node { } typ = op.X } - n := embedded(p.packname(typ), localpkg) + + sym := p.packname(typ) + n := nod(ODCLFIELD, newname(lookup(sym.Name)), oldname(sym)) + n.SetEmbedded(true) + if isStar { n.Right = p.nod(op, OIND, n.Right, nil) } |