diff options
| author | Than McIntosh <thanm@google.com> | 2023-03-09 13:20:01 -0500 |
|---|---|---|
| committer | Than McIntosh <thanm@google.com> | 2023-03-09 20:09:52 +0000 |
| commit | 269bdcd56866d5cd5789164d3f7420a66c524a8a (patch) | |
| tree | 2ca227da52f4b5b5a69cb23f0f49336729cae2ae /src/cmd/compile/internal/base | |
| parent | 24017148ca8a669debbddba56d69769dc47d5c71 (diff) | |
| download | go-269bdcd56866d5cd5789164d3f7420a66c524a8a.tar.xz | |
cmd/compile: remove -wrapglobalmapinit flag
Remove the compiler's "-wrapglobalmapinit" flag; it is potentially
confusing for users and isn't appropriate as a top level flag. Move
the enable/disable control to the "wrapglobalmapctl" debug flag
(values: 0 on by default, 1 disabled, 2 stress mode). No other changes
to compiler functionality.
Change-Id: I0d120eaf90ee34e29d5032889e673d42fe99e5dc
Reviewed-on: https://go-review.googlesource.com/c/go/+/475035
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/base')
| -rw-r--r-- | src/cmd/compile/internal/base/debug.go | 6 | ||||
| -rw-r--r-- | src/cmd/compile/internal/base/flag.go | 2 |
2 files changed, 3 insertions, 5 deletions
diff --git a/src/cmd/compile/internal/base/debug.go b/src/cmd/compile/internal/base/debug.go index 288c2d82ef..ec20b18134 100644 --- a/src/cmd/compile/internal/base/debug.go +++ b/src/cmd/compile/internal/base/debug.go @@ -50,11 +50,11 @@ type DebugFlags struct { WB int `help:"print information about write barriers"` ABIWrap int `help:"print information about ABI wrapper generation"` MayMoreStack string `help:"call named function before all stack growth checks" concurrent:"ok"` - PGOInlineCDFThreshold string `help:"cummulative threshold percentage for determining call sites as hot candidates for inlining" concurrent:"ok"` + PGOInlineCDFThreshold string `help:"cumulative threshold percentage for determining call sites as hot candidates for inlining" concurrent:"ok"` PGOInlineBudget int `help:"inline budget for hot functions" concurrent:"ok"` PGOInline int `help:"debug profile-guided inlining"` - WrapGlobalMapDbg int "help:\"debug trace output for global map init wrapping\"" - WrapGlobalMapStress int "help:\"run global map init wrap in stress mode (no size cutoff)\"" + WrapGlobalMapDbg int `help:"debug trace output for global map init wrapping"` + WrapGlobalMapCtl int `help:"global map init wrap control (0 => default, 1 => off, 2 => stress mode, no size cutoff)"` ConcurrentOk bool // true if only concurrentOk flags seen } diff --git a/src/cmd/compile/internal/base/flag.go b/src/cmd/compile/internal/base/flag.go index 4baff74917..ccd63f6368 100644 --- a/src/cmd/compile/internal/base/flag.go +++ b/src/cmd/compile/internal/base/flag.go @@ -123,7 +123,6 @@ type CmdFlags struct { TraceProfile string "help:\"write an execution trace to `file`\"" TrimPath string "help:\"remove `prefix` from recorded source file paths\"" WB bool "help:\"enable write barrier\"" // TODO: remove - WrapGlobalMapInit bool "help:\"wrap global map large inits in their own functions (to permit deadcode)\"" PgoProfile string "help:\"read profile from `file`\"" // Configuration derived from flags; not a flag itself. @@ -164,7 +163,6 @@ func ParseFlags() { Flag.LinkShared = &Ctxt.Flag_linkshared Flag.Shared = &Ctxt.Flag_shared Flag.WB = true - Flag.WrapGlobalMapInit = true Debug.ConcurrentOk = true Debug.InlFuncsWithClosures = 1 |