diff options
| author | David Chase <drchase@google.com> | 2022-11-04 11:23:12 -0400 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2022-11-04 20:28:30 +0000 |
| commit | 1bcfdc777ad38bbb4faec8e1db2eaa92873f4e10 (patch) | |
| tree | bcf83ce8b2dccff35c02d0e98a7868f2169b0a6f /src/cmd/compile/internal/base | |
| parent | ada9385a5fd3908243dbb514040c07a41e4806bb (diff) | |
| download | go-1bcfdc777ad38bbb4faec8e1db2eaa92873f4e10.tar.xz | |
cmd/compile: change the multiple (gossa)hash separator from ; to /
Semicolon has bad copy-paste ergonomics; it requires quoting.
Slash is okay, and won't be a separator ever in debug strings
because it is already used in e.g. ssa/phase/debug=etc.
Change-Id: I493360e9282666eea1a342971a77df2ebd6c92ad
Reviewed-on: https://go-review.googlesource.com/c/go/+/447975
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/base')
| -rw-r--r-- | src/cmd/compile/internal/base/hashdebug.go | 2 | ||||
| -rw-r--r-- | src/cmd/compile/internal/base/hashdebug_test.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/base/hashdebug.go b/src/cmd/compile/internal/base/hashdebug.go index c93d042f71..609f80393e 100644 --- a/src/cmd/compile/internal/base/hashdebug.go +++ b/src/cmd/compile/internal/base/hashdebug.go @@ -140,7 +140,7 @@ func NewHashDebug(ev, s string, file writeSyncer) *HashDebug { hd.no = true return hd } - ss := strings.Split(s, ";") + ss := strings.Split(s, "/") hd.matches = append(hd.matches, toHashAndMask(ss[0], ev)) // hash searches may use additional EVs with 0, 1, 2, ... suffixes. for i := 1; i < len(ss); i++ { diff --git a/src/cmd/compile/internal/base/hashdebug_test.go b/src/cmd/compile/internal/base/hashdebug_test.go index decdf5ce0f..b74169f895 100644 --- a/src/cmd/compile/internal/base/hashdebug_test.go +++ b/src/cmd/compile/internal/base/hashdebug_test.go @@ -130,7 +130,7 @@ func TestHashNoMatch(t *testing.T) { func TestHashSecondMatch(t *testing.T) { ws := new(bufferWithSync) - hd := NewHashDebug("GOSSAHASH", "001100;0011", ws) + hd := NewHashDebug("GOSSAHASH", "001100/0011", ws) check := hd.DebugHashMatch("bar") msg := ws.String() |